Remove any type in DiffView and ReviewCard #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
bryanjenningz
commented
Sep 30, 2022
| @@ -60,7 +60,7 @@ const ReviewButtons: React.FC<{ | |||
| const [addComment] = useAddCommentMutation() | |||
| const [accept] = useMutation(ACCEPT_SUBMISSION) | |||
| const [reject] = useMutation(REJECT_SUBMISSION) | |||
| const reviewSubmission = (review: any) => async () => { | |||
| const reviewSubmission = (review: typeof accept) => async () => { | |||
There was a problem hiding this comment.
When reviewSubmission is called, the review argument will be either accept or reject which both have the same type, so we can simply put typeof accept or typeof reject here instead of any.
Codecov Report
@@ Coverage Diff @@
## master #2373 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 183 183
Lines 3208 3208
Branches 848 848
=========================================
Hits 3208 3208
|
flacial
approved these changes
Sep 30, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.