Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NewButton the same size across breakpoints #2346

Merged
merged 2 commits into from
Sep 25, 2022
Merged

Make NewButton the same size across breakpoints #2346

merged 2 commits into from
Sep 25, 2022

Conversation

bryanjenningz
Copy link
Collaborator

@bryanjenningz bryanjenningz commented Sep 25, 2022

Closes #2343

Changes:

  • Removes NewButton size changes across breakpoints so it looks more consistent and makes the button styling more simple.
  • Makes NewButton easier to see and press on mobile (for example, the DOJO exercises "Solve Exercises" button was pretty small on mobile before, etc).

How to test:

  • Go to the pages that use NewButton and make sure everything looks good on mobile.
    • Here are all the pages that use NewButton:
      • /exercises/js0
      • /admin/lessons/js0/introduction
      • /curriculum/js0/mentor

/exercises/js0 page on mobile (DOJO exercise list):
exercise-list-mobile

/exercises/js0 page on mobile (DOJO exercise card):
exercise-card-mobile

/exercises/js0 page on mobile (DOJO exercise card answered):
exercise-card-mobile-answered

/admin/lessons/js0/introduction on mobile (this wasn't designed for mobile before this pull request so it doesn't look as good here but this can be fixed in a subsequent pull request):
admin-curriculum-lessons-introduction-mobile

/curriculum/js0/mentor on mobile (this page isn't designed for mobile so it doesn't look as good here):
curriculum-lesson-mentor-mobile

@vercel
Copy link

vercel bot commented Sep 25, 2022

@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 25, 2022 at 6:17PM (UTC)

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #2346 (df1d5de) into master (54bca2f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2346   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         3178      3178           
  Branches       850       836   -14     
=========================================
  Hits          3178      3178           

@bryanjenningz bryanjenningz merged commit b218f7d into garageScript:master Sep 25, 2022
@bryanjenningz bryanjenningz deleted the make-new-button-the-same-size-across-breakpoints branch September 25, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make DOJO "solve exercises" button the same size across all breakpoints
2 participants