fix: Unlink/Connect discord buttons appears for any profiles #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
flacial
changed the title
…ppear-for-other-users
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 180 180
Lines 3140 3148 +8
Branches 835 838 +3
=========================================
+ Hits 3140 3148 +8
|
bryanjenningz
approved these changes
Sep 17, 2022
…ppear-for-other-users
…er-users' of github.com:flacial/c0d3-app into 2279-unlink-to-discord-button-should-not-appear-for-other-users
…ppear-for-other-users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2279
Currently, when you access a profile that isn't yours, it looks like this:
Image
The buttons show up even though it's not your profile. Merging this PR will fix it by comparing the username in the session to the profile's user username.
Image
To test it:
/profile/leetcoderCONNECT TO DISCORDbutton doesn't appear