fix: Submission review count shows with none submissions #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## master #2273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 177 177
Lines 3031 3029 -2
Branches 803 806 +3
=========================================
- Hits 3031 3029 -2
|
bryanjenningz
approved these changes
Sep 9, 2022
anthonykhoa
reviewed
Sep 9, 2022
HS-90
approved these changes
Sep 9, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonykhoa
reviewed
Sep 10, 2022
| } | ||
| return acc | ||
| }, 0) | ||
| const submissions = get(data, 'submissions') || [] |
There was a problem hiding this comment.
We dont have to do || [] ourselves, lodash provides third parameter for that use case
const submissions = get(data, 'submissions', [])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2208
Merging this PR will stop the submissions review count from being displayed if there's no submissions.
Before:
After:
To test it:
/curriculum