-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AdminLessonNav more generic #2272
Make AdminLessonNav more generic #2272
Conversation
@bryanjenningz is attempting to deploy a commit to the c0d3-prod Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #2272 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 177 177
Lines 3010 3010
Branches 801 801
=========================================
Hits 3010 3010
|
@@ -12203,6 +12163,44 @@ exports[`Storyshots Components/ModalCard Small 1`] = ` | |||
</button> | |||
`; | |||
|
|||
exports[`Storyshots Components/NavCard Basic 1`] = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This snapshot is identical to the snapshot that got removed above with the only difference being the name is now "Storyshots Components/NavCard Basic 1" instead of "Storyshots Components/AdminLessonNav Basic 1" and the classNames now use the more generic "navCard__" prefix instead of "lesson__".
I figured the name NavCard made more sense because it's a Card and it also contains Nav items and when I searched NavCard (https://github.com/garageScript/c0d3-app/search?q=NavCard), this name wasn't taken so it seemed like a nice short name that describes what it is pretty well.
background-color: color.change(variables.$primary, $lightness: 95%); | ||
color: $dark_primary; | ||
transition: background-color 0.3s ease-out; | ||
} | ||
|
||
.lessons_tabs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This .lessons_tabs CSS class wasn't being used (https://github.com/garageScript/c0d3-app/search?q=lessons_tabs) so I deleted it.
Closes #2268
This pull request changes:
How to test: