-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS2 Part 3 syntax error corrected #2205
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e04ba1f
syntax error change on JS2 part3 corrected
pauly48 543a880
Merge branch 'master' of https://github.com/pauly48/c0d3-app
pauly48 b788b65
corrected 1st part of syntax error after solution syntax error
pauly48 0bb9a79
Merge branch 'master' into master
SlyBouhafs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the semicolon at the end on this line as well as line 1419? I just searched through the file, I don't see any javascript code using the semicolon, so it shouldn't be here either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anthony, I posted the reason for semicolon in the Discord bugs & feedback section with the screenshots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code requires semi-colon here.
A person can try to run the code without semi-colon but rather with just space, both VS CODE and RUNJS will throw errors.
Screenshots with errors
https://media.discordapp.net/attachments/836343487531712512/1009987825606869102/unknown.png?width=972&height=663
https://media.discordapp.net/attachments/836343487531712512/1009987913280393296/unknown.png?width=1440&height=246
Screenshots with output without errors
https://media.discordapp.net/attachments/836343487531712512/1009988225990930604/unknown.png
https://media.discordapp.net/attachments/836343487531712512/1009988226452307978/unknown.png?width=1019&height=663
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Can you please put this in the PR description? And if there was any other bugs you solved with this code change, can you also include it in the PR description too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anthony, description has been updated as requested. Thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pauly48 approved, but I think you might have forgotten to save the updates you made to the PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i see you included the image. Please include the explanation as well