Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DropdownMenu to set selected item as active one #2189

Conversation

flacial
Copy link
Member

@flacial flacial commented Aug 15, 2022

Closes #2188
Related to #1975

Problem

When an item is selected, it doesn't get set as the active item.

Solution

Create a state and set the selected item as the active one.

Test

  1. Click the dropdown menu
  2. Select an item
  3. Notice how it gets set as the dropdown menu text next to the arrow

Storybook

Makes it possible to set the selected item as the active one
@vercel
Copy link

vercel bot commented Aug 15, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Sep 3, 2022 at 5:14AM (UTC)

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #2189 (690f9e2) into master (7335130) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          174       174           
  Lines         2958      2960    +2     
  Branches       797       795    -2     
=========================================
+ Hits          2958      2960    +2     
Impacted Files Coverage Δ
components/DropdownMenu.tsx 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the DropdownMenu to set the selected item
3 participants