Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Template Setup #2

Merged
merged 7 commits into from
Jan 23, 2020
Merged

Initial Template Setup #2

merged 7 commits into from
Jan 23, 2020

Conversation

hwong0305
Copy link
Collaborator

#1

  • Setup Next.JS with typescript.
  • Created EsLint configuration

bryanjenningz
bryanjenningz reviewed Jan 23, 2020
View reviewed changes
tsconfig.json Outdated
"noUnusedLocals": true,
"noUnusedParameters": true,
"resolveJsonModule": true,
"skipLibCheck": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These compiler options look pretty good. Is there a reason why "skipLibCheck": true is being used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no particular reason. I kept the default settings generated by next.js.

@hwong0305 hwong0305 merged commit fa3d88a into master Jan 23, 2020
@hwong0305 hwong0305 deleted the initial branch January 23, 2020 06:50
@hwong0305 hwong0305 mentioned this pull request Jan 23, 2020
Closed
@songz songz mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanjenningz bryanjenningz bryanjenningz approved these changes

@songz songz songz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwong0305 @songz @bryanjenningz