Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flag columns to Exercise #1993

Merged

Conversation

flacial
Copy link
Member

@flacial flacial commented Jun 17, 2022

Related to #1990

This PR adds the flagged, flaggedBy, and flaggedReason. flagged refers to exercises that were flagged by students or mentors to be reviewed by the Admin. flaggedReason is the reason for the flag. flaggedBy is the user who flagged it.

@vercel
Copy link

vercel bot commented Jun 17, 2022

@flacial is attempting to deploy a commit to the c0d3-prod Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
c0d3-app ✅ Ready (Inspect) Visit Preview Jun 19, 2022 at 8:42AM (UTC)

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1993 (405b0b2) into master (51dcd7b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1993   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         2881      2881           
  Branches       760       760           
=========================================
  Hits          2881      2881           

prisma/schema.prisma Outdated Show resolved Hide resolved
@JasirZaeem
Copy link
Member

The flaggedBy column you had proposed would be useful I suggest you add that in this PR as well.

@flacial
Copy link
Member Author

flacial commented Jun 18, 2022

The flaggedBy column you had proposed would be useful I suggest you add that in this PR as well.

I had some issues with having two columns with User type. I'll look into Prisma doc and add it.

@@ -156,6 +156,7 @@ model User {
modules Module[]
exercises Exercise[]

Exercise Exercise[] @relation("flaggedBy")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like flaggedExercises will be a more suitable and descriptive name for this field.

@flacial flacial merged commit e03822b into garageScript:master Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants