-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more examples into the manual for StructureDescription #969
Add more examples into the manual for StructureDescription #969
Conversation
Further, correct the old examples from gap-system#763. Add some extra tests. Remove InfoPerformance from tst files as per 392ad82.
Current coverage is 49.55% (diff: 100%)@@ master #969 diff @@
==========================================
Files 424 424
Lines 222953 222953
Methods 3430 3430
Messages 0 0
Branches 0 0
==========================================
+ Hits 110234 110489 +255
+ Misses 112719 112464 -255
Partials 0 0
|
Thanks @hungaborhorvath - looks obviously ok to me, and tests passed. Will rebase it now. |
@hungaborhorvath there are further issues with
|
@alex-konovalov Thank you, I did not catch this previously. At first I thought that we should simply use the "nice" option here, because that would give stable output: However, using the "nice" option reveals a bug somewhere. I am not entirely sure where, yet. It seems to be with nice monomorhpisms of which I have no idea about. I am debugging this, but it might take some time. Should these tests be commented out until I figure out the problem, or shall we leave them? Or should I open an issue with this? |
@alex-konovalov Ok, so I have reported it in #973, and I have no idea how to resolve this. It involves that GAP (using the presentation of these groups) cannot decide if a list of subgroups is already an element of a set or not. |
Thanks @hungaborhorvath - let's continue discussion in #973. I though about opening a new issue myself, but decided to wait until you'll confirm that there is no straightforward fix. |
Further, correct the old examples from #763.
Add some extra tests.
Remove InfoPerformance from tst files as per 392ad82.