Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in initialisation of TmpPPerm #948

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

james-d-mitchell
Copy link
Contributor

@james-d-mitchell james-d-mitchell commented Nov 14, 2016

Please make sure that this pull request:

  • is submitted to the correct branch (the stable branch is only for bugfixes)
  • contains an accurate description of changes for the release notes below
  • provides new tests or relies on existing ones
  • correctly refers to other issues and related pull requests

Tick all what applies to this pull request

  • Adds new features
  • Improves and extends functionality
  • Fixes bugs that could lead to crashes
  • Fixes bugs that could lead to incorrect results
  • Fixes bugs that could lead to break loops

Write below the description of changes (for the release notes)

The function ResizeTmpPPerm did not correctly initialise TmpPPerm, the
bag was too small. A similar fix was made relatively recently by CAJ to
ResizeTmpTrans. I can't provide an example where this causes a problem,
but it was causing a seg fault in the tests for the Semigroups package.

The function ResizeTmpPPerm did not correctly initialise TmpPPerm, the
bag was too small. A similar fix was made relatively recently by CAJ to
ResizeTmpTrans.
@james-d-mitchell james-d-mitchell added this to the GAP 4.9.0 milestone Nov 14, 2016
@james-d-mitchell james-d-mitchell added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) labels Nov 14, 2016
@codecov-io
Copy link

Current coverage is 48.72% (diff: 0.00%)

Merging #948 into master will decrease coverage by 0.02%

@@             master       #948   diff @@
==========================================
  Files           424        424          
  Lines        222138     222137     -1   
  Methods        3431       3431          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits         108312     108245    -67   
- Misses       113826     113892    +66   
  Partials          0          0          

Powered by Codecov. Last update d6c3446...6439b4f

@ChrisJefferson
Copy link
Contributor

This is obviously right.

@ChrisJefferson ChrisJefferson merged commit 7183c69 into gap-system:master Nov 15, 2016
@james-d-mitchell james-d-mitchell deleted the fix-pperm branch November 15, 2016 20:28
@wilfwilson
Copy link
Member

Yes I remember that this was causing segfaults. Glad it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants