Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShortestVector #941

Merged
merged 2 commits into from
Nov 9, 2016
Merged

Conversation

markuspf
Copy link
Member

@markuspf markuspf commented Nov 8, 2016

Closes #838 and #839

An empty list could be left when "positive" is given
as a parameter to ShortestVectors.
@codecov-io
Copy link

Current coverage is 48.89% (diff: 100%)

Merging #941 into master will increase coverage by 0.01%

@@             master       #941   diff @@
==========================================
  Files           424        424          
  Lines        222089     222089          
  Methods        3426       3426          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits         108554     108596    +42   
+ Misses       113535     113493    -42   
  Partials          0          0          

Powered by Codecov. Last update 1e4aa07...ebdfeb1

@markuspf markuspf merged commit 3f7ca3d into gap-system:master Nov 9, 2016
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Nov 9, 2016
@markuspf markuspf deleted the fix-shortest-vector branch August 25, 2017 09:26
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants