Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting nested alarms in the stable-4.8 branch #668

Conversation

olexandr-konovalov
Copy link
Member

This reverts the following commits:
53e0a18
b8f1091
96c7532
ce694b2

since this code is not yet ready for the release.

This reverts the following commits:
53e0a18
b8f1091
96c7532
ce694b2

since this code is not yet ready for the release.
@olexandr-konovalov olexandr-konovalov added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Mar 10, 2016
@markuspf
Copy link
Member

If you hold back on this for a while, I think I know what is going wrong here. For reference, the linux man page for setitimer states that valid values for tv_usec are between 0 and 999999. My change tries to put 1000000 in microseconds. Not sure why this only sometimes fails yet.

@markuspf
Copy link
Member

Mhm, actually the code checks these conditions. I'll have to look more closely which implementation of the timers is actually used and why wrong values are passed.

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.8.3 milestone Mar 12, 2016
@olexandr-konovalov
Copy link
Member Author

@markuspf any hope, or should we merge this and retry this after 4.8.3?

@olexandr-konovalov
Copy link
Member Author

@markuspf achieved some progress in PR #672 submitted to the master branch, but to keep with the release schedule, I am going to merge this and revert nested alarms in the stable-4.8 branch. We may attempt to introduce them in GAP 4.8.4.

@olexandr-konovalov olexandr-konovalov removed the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Mar 16, 2016
olexandr-konovalov pushed a commit that referenced this pull request Mar 16, 2016
Reverting nested alarms in the stable-4.8 branch
@olexandr-konovalov olexandr-konovalov merged commit c5cbe2a into gap-system:stable-4.8 Mar 16, 2016
@olexandr-konovalov olexandr-konovalov deleted the revert-nested-alarms-stable branch March 17, 2016 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants