More than 3 minor corrections that should make the 4.8.3 release #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These all look good to me (although I haven't carefully checked all the logic). I know it's boring to ask, but would it be reasonable to add some tests? |
hulpke
changed the title
|
@ChrisJefferson The will is there. Alas: c30f7b7 is based on an error report on stackexchange that the author by now deleted -- I cannot recreate it easily. 9068a12 (Issue #626) was a wrong result that actually should run into an error or nonterminating loop. No idea how to test this :-( . fb4b6ae was a big example using other code of mine. 12f146f got caught by existing tests. The two new additions at least have their own test. |
…only one generator.
…ad of a subgroup.
that were never intended for infinite groups. This closes gap-system#626.
classes fallback routine will run.
Avoid a multiplication scal*vec if vec is an empty vector in compact representation. This fixes the bug reported by macaj.
not socle subgroup. (Otherwise Projection images are not clearly defined). This fixes the bug reported by Ignat Soroko.
Do not pre-store LinearActionBasis, as the special method stores dependent information. Also avoid unneeded natural GL test.
markuspf
added a commit
that referenced
this pull request
Mar 4, 2016
More than 3 minor corrections that should make the 4.8.3 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.