Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix OpenBSD CI test #5814

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

fingolfin
Copy link
Member

Attempt to fix OpenBSD CI tests. But I am stumbling the dark here. Perhaps @dimpase can help?

@fingolfin fingolfin added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: infrastructure labels Oct 14, 2024
@dimpase
Copy link
Member

dimpase commented Oct 14, 2024

Is it autoconf-related?
OpenBSD needs explicit setting of autoconf and automake versions via environment variables.
I.e. GAP's ./autogen.sh needs

export AUTOCONF_VERSION=2.71

@@ -382,7 +382,7 @@ jobs:
envs: 'AUTOCONF_VERSION'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AUTOCONF_VERSION is set to 2.71 in line 367 above and passed on here, but OpenBSD started to say this recently:

  Running prepare: pkg_add bash git gmake autoconf-2.71 gmp
  
  exec ssh: pkg_add bash git gmake autoconf-2.71 gmp
  /usr/bin/bash /home/runner/work/_actions/vmactions/openbsd-vm/v1/run.sh execSSHSH
  Config file: openbsd-7.6.conf
  quirks-7.50 signed on 2024-10-13T18:21:26Z
  Can't find autoconf-2.71
  The following new rcscripts were installed: /etc/rc.d/gitdaemon
  See rcctl(8) for details.
  New and changed readme(s):
  	/usr/local/share/doc/pkg-readmes/git
  Couldn't install autoconf-2.71

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be autoconf-2.71p0 I think.

(pkg_add is interactive; pkg_add autoconf enters a dialog with a menu of versions to choose from; the only 2.71 one is as above)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an autoconf-2.72p0 too, it seems.

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, with my latest commit, OpenBSD CI works.

@fingolfin
Copy link
Member Author

Thanks Dima!

(Just wondering, out of curiosity: do you know why it worked before and now needs the p0?)

@fingolfin fingolfin merged commit 3cf4092 into gap-system:master Oct 14, 2024
30 checks passed
@fingolfin fingolfin deleted the mh/ci-tweak-openbsd branch October 14, 2024 11:23
@dimpase
Copy link
Member

dimpase commented Oct 14, 2024

(Just wondering, out of curiosity: do you know why it worked before and now needs the p0?)

They renamed the package as they applied a patch:
openbsd/ports@953c48a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants