Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better input validation for GModuleByMats #5813

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Better input validation for GModuleByMats #5813

merged 1 commit into from
Oct 14, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin added topic: library release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Oct 14, 2024
ThomasBreuer
ThomasBreuer approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Besides improving the input validation, the changes improve also the support for MatrixObj input.

(The CI test "Test in OpenBSD" is required and fails, but the reason for the failure is not related to the proposed changes.)

@fingolfin fingolfin enabled auto-merge (squash) October 14, 2024 20:52
@fingolfin fingolfin merged commit 520a378 into gap-system:master Oct 14, 2024
30 checks passed
@fingolfin fingolfin deleted the mh/GModuleByMats-arg-checks branch October 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @ThomasBreuer