Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve subgroup conjugacy of permutation groups #5514

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Sep 29, 2023

Subgroup conjugacy in permutation groups uses orbit structures, factor groups, and brute force test if small index before attempting backtrack.
Use this also in subgroup lattice computations, in particular in LowLayerSubgroups.

Text for release notes

Subgroup conjugacy of permutation groups has been improved

for permutation groups -- improve conjugcy test stage.
@hulpke hulpke added release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes kind: performance improvement labels Sep 29, 2023
Added ClusterConjugacyPermgroups. Use if degree larger or for
SubgroupsOrbits.

Remove commented out debugging and dead code
@hulpke hulpke force-pushed the enhancements branch 3 times, most recently from 66e0518 to 17d763b Compare September 29, 2023 17:48
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Does this help with issue #3718?

@hulpke
Copy link
Contributor Author

hulpke commented Oct 6, 2023

Does this help with issue #3718?

Probably not in a meaningful way. One could use similar ideas, but in Sn should immediately write down certain elements or subgroups from their combinatorial properties.

@fingolfin fingolfin merged commit f64e305 into gap-system:master Oct 11, 2023
22 checks passed
@fingolfin fingolfin changed the title ENHANCE: Subgroup conjugacy in permutation groups Improve subgroup conjugacy of permutation groups Jan 23, 2024
@fingolfin fingolfin added release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: performance bugs or enhancements related to performance (improvements or regressions) and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: performance bugs or enhancements related to performance (improvements or regressions)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants