Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCE: FittingFreeLiftSetup #5510

Merged
merged 2 commits into from
Sep 29, 2023
Merged

ENHANCE: FittingFreeLiftSetup #5510

merged 2 commits into from
Sep 29, 2023

Conversation

hulpke
Copy link
Contributor

@hulpke hulpke commented Sep 27, 2023

Improve implementartion of FittingFreeLiftSetup. In particular enable inheritance of information when group is created.
Better interaction with permutation groups and their homomorphisms.

Use cachedFFS to build new map if applicable.
Store new FFHoms in Pool
Reduce generator number of subgroups, also in maxsub code.
Better preimage under ffhom for fitting free.
(Otherwise use orbits first to see whether kernel elements are required, before
calculating orders.)
Avoid trivial images slowing down setup for permhom
Avoid hom on trivial subgroup w/o parent
@hulpke hulpke added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Sep 27, 2023
@hulpke hulpke force-pushed the additions branch 2 times, most recently from dbeb86e to d21eb04 Compare September 28, 2023 00:34
And all the pointless extra work because of the stupid gaplint
@fingolfin fingolfin merged commit 7d29977 into gap-system:master Sep 29, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants