-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a rare error message in isomorphism test #5298
Conversation
198c5cf
to
d195728
Compare
The Otherwise this PR looks good to me. However, I would prefer to first merge PR #5275; afterwards this and a a few other PRs may need to be adjusted, which I will take care of myself (i.e. no need for @hulpke to update this or the other PR), and then I hope we can merge both of your PRs soon. Sorry for the delay. |
Thank you.
While I consider this PR (and gaplint) as solutions in search of a problem, I can live with this. Thanks for the update. |
Double cosets in Dixon-Schneider can use coset perm action, if degree is small
use presentation for factor and closure, rather than coKernelGenerators. This requires fewer products in preimage.
when inserting certain subgroups. This fixes a bug reported by B. Sambale in the forum on 12/24/2022
can lead no natural homomorphism into formal direct product, not efficient.
This is relevant when forming factor groups as subdirect products.
This PR apparently contains simultaneously a bug fix, a new feature and enhancements, thus would need multiple entries in the release notes and can't just be handled via the title. But since also the "release notes: use title" was set, I assume only the bugfix is meant to be in the release notes. I've thus adjusted the labels to only indicate the bug fix, so as to not mislead the script generating the release notes. |
@fingolfin |
This fixes a bug reported by B. Sambale in the forum on 12/24/2022: When adding to the series, the relevant radical automorphisms were only computed in one case, not both. This will lead to an error message if wrong.
It also contains updates to fitting free setup so that it will work for hybrid groups.