Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to permrep of fp group #5229

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Improvement to permrep of fp group #5229

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5433f8
When acting on subgroups, be more open to reduce permdegree.
hulpke Nov 12, 2022
465a5ed
Use larger perfect groups database
hulpke Nov 12, 2022
a7a8956
MinimalGeneratingSet for groups
hulpke Nov 7, 2022
53b3985
ENHANCE: Improvement to perm rep of fp.
hulpke Nov 26, 2022
c23bc08
REBASE: Subsequent manual changes
hulpke Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lib/grp.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,16 @@ local r,i,j,u,f,q,n,lim,sel,nat,ok,mi;
od;
f:=FreeGroup(r);
ok:=false;
if IsPerfectGroup(g) then
if not IsSolvableGroup(g) then
if n=false then
n:=ShallowCopy(NormalSubgroups(g));
# all perfect groups of order <15360 *are* 2-generated
lim:=15360;
if IsPerfectGroup(g) then
# all perfect groups of order <15360 *are* 2-generated
lim:=15360;
else
# all groups of order <8 *are* 2-generated
lim:=8;
fi;
n:=Filtered(n,x->IndexNC(g,x)>=lim and Size(x)>1);
SortBy(n,x->-Size(x));
mi:=MinimalInclusionsGroups(n);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Expand Down