-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite gac
to not use libtool
#4746
Rewrite gac
to not use libtool
#4746
Conversation
96f9bb7
to
a8acadc
Compare
Compiling NormalizInterface, we get:
That's something to be fixed in NormalizInterface (not quite sure how yet, but one step after the other) UPDATE: seems libtool turns UPDATE2: on macOS, it seems to be ignored? UPDATE3: ... though on macOS, one can still path the UPDATE4: actually the latest NormalizInterface 1.3.1 won't use |
This comment was marked as resolved.
This comment was marked as resolved.
019086a
to
2605037
Compare
2605037
to
2f72d19
Compare
4b0e4cd
to
2081746
Compare
Two failures left, both in building packages:
|
a68cdca
to
bd214e7
Compare
610032f
to
2d438bf
Compare
|
This comment was marked as outdated.
This comment was marked as outdated.
ee22ba8
to
115a51e
Compare
I'll try and see if I can get this ready for GAP 4.12.0. Perhaps @ChrisJefferson has an idea why NormalizInterface might crash? |
115a51e
to
9103ac7
Compare
d95730b
to
659598d
Compare
@ChrisJefferson this is finally ready for review and merging -- with the latest NormalizInterface update, that last blocker has been removed! Also, the patch is now fairly small, as I already got most of the changes merged separately. |
659598d
to
0c8c653
Compare
gac
to not use libtool
This is incomplete work in progress, but I wanted to post it here
just for reference. I'll hopefully be able to resume work on this
in the not so distant future.
For now, things to be done include:
gac
work in all situationsadd a test which doesnot necessary here, this is to be done for themake install
and then runs the test suite using that installed version (including the mockpkg kernel extension test mentioned above)make install
PR Add support formake install
(still somewhat experimental, but ready to be tested by downstream packagers) #4492Resolves #4172
Resolves #1307