Forbid installing an operation as method for itself, as that leads to crashes #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
|
The problem is that irredsol 1.4.2 does not actually contain the fix; I made a corresponding comment at bh11/irredsol#12 |
wilfwilson
approved these changes
Jun 7, 2021
fingolfin
force-pushed
the
mh/dont-InstallMethod-self
branch
from
1038f01
to
4ba795c
Compare
wilfwilson
added
release notes: to be added
|
From a quick look at the code, it seems that irredsol 1.4.3 has the right fix, so hopefully this can be merged soon. |
Triggering such a "method" would lead to a segfault due to a stack overflow. Of course one can still trigger this by e.g. having two operations `foo` and `bar, and installing `foo` as method for `bar` and vice-versa. But that is far less likely to happen by accident. Also, it seems better to fix at least some instances of this issue than to give up because we can't fix it completely.
fingolfin
force-pushed
the
mh/dont-InstallMethod-self
branch
from
4ba795c
to
c403e1b
Compare
|
@alex-konovalov to make progress with this, we need irredsol 1.4.3 in the package distribution. But https://github.com/gap-system/gap/wiki/Package-updates-status was last updated in May... |
|
Done - they were as on 2nd June, now as of today. Updated tables of contents at https://github.com/gap-system/gap-distribution/releases/tag/package-archives and https://github.com/gap-system/gap/wiki/Package-updates-status |
|
Seems like CI tests are passing, except for some unrelated quirks. |
fingolfin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggering such a "method" would lead to a segfault due to a stack overflow.
Of course one can still trigger this by e.g. having two operations
fooandbar, and installingfooas method forbarand vice-versa. But that is farless likely to happen by accident. Also, it seems better to fix at least some
instances of this issue than to give up because we can't fix it completely.
(This used to be PR #4349 but I accidentally deleted the underlying branch, it seems, so I had to reopen it in a fresh PR)