CI: temporarily remove coverage from macOS job #4387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the macOS job is failing because IO is not building, which is requiring by the code coverage system, and this causes the job to fail. See: gap-system#4374 By adding NO_COVERAGE=1 to this job, IO will no longer need to be compiled. Obviously, in the long term we want coverage on this job, and we want to be able to compile IO, but this will get the CI running for the rest of GAP in a non-controversial way in the meantime, I hope.
wilfwilson
added
release notes: not needed
|
Or wait a day or two when I'll have a chance to push out the fixes to io and any other affected package. but if you think it's this urgent... shrug |
|
shrug from me too 🙂. It's not particularly urgent, but then again it took almost no effort to create this one-line PR, and now it stands ready as a backup in case those fixes end up taking longer than expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the macOS job is failing because IO is not building, which is requiring by the code coverage system, and this causes the job to fail. See #4374.
By adding
NO_COVERAGE=1to this job, IO will no longer need to be compiled. Obviously, in the long term we want coverage on this job, and we want to be able to compile IO, but this will get the CI running for the rest of GAP in a non-controversial way in the meantime, I hope.