Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow function-call syntax for evaluating univariate polynomials #4296

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Allow function-call syntax for evaluating univariate polynomials #4296

merged 1 commit into from
Mar 18, 2021

Conversation

wucas
Copy link
Contributor

@wucas wucas commented Feb 28, 2021 •
edited
Loading

Description

This PR implements #4283 similarly to #3901. Specifically for a univariate polynomial p the call p( x ) is treated as Value(p,x).

Checklist for pull request reviewers

  • proper formatting
  • usage of relevant labels
  • runnable tests
  • lines changed in commits are sufficiently covered by the tests
  • adequate pull request title
  • well formulated text for release notes
  • relevant documentation updates
  • sensible comments in the code

@wucas wucas added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Feb 28, 2021
@wucas wucas requested a review from fingolfin February 28, 2021 17:55
fingolfin
fingolfin reviewed Feb 28, 2021
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

lib/ratfun.gd Outdated Show resolved Hide resolved
lib/ratfun.gi Outdated Show resolved Hide resolved
fingolfin
fingolfin requested changes Mar 2, 2021
View reviewed changes
lib/ratfun.gi Show resolved Hide resolved
@fingolfin fingolfin linked an issue Mar 4, 2021 that may be closed by this pull request
Add convenient way to evaluate univariate polynomials. #4283
Closed
@fingolfin fingolfin merged commit 0667812 into gap-system:master Mar 18, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
@wucas wucas deleted the lw/univPolyCal branch May 26, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add convenient way to evaluate univariate polynomials.
2 participants
@wucas @fingolfin