Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DirectoriesPackageLibrary, DirectoriesPackagePrograms when they are called during package loading #4206

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

ThomasBreuer
Copy link
Contributor

... for the case that another package is the current package to be loaded at the time when the function gets called.

Apparently this did not happen until now, otherwise it would have been observed earlier.

Text for release notes

Suppose that one of the functions DirectoriesPackageLibrary, DirectoriesPackagePrograms is called with first argument "a", and that this call happens while another package with name "b", say, gets loaded, in the sense that GAPInfo.CurrentPackage is bound to an info record for "b".
Before the fix, the directory path in question for "b" was returned. After the fix, the path for "a" is returned.

... for the case that *another* package is the current package
to be loaded at the time when the function gets called.

Apparently this did not happen until now,
otherwise it would have been observed earlier.
@ThomasBreuer ThomasBreuer added kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker) release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jan 6, 2021
@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Jan 13, 2021
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Sorry for reviewing this so later, somehow I didn't notice this PR :-(

Out of curiosity, where / how did you encounter this?

@ThomasBreuer
Copy link
Contributor Author

@fingolfin There will be code in the next version of the AtlasRep package which checks for possible "shortcuts":
If some other GAP package provides a data extension which is distributed together with that package then AtlasRep decides to prefer the locally available files to remote ones --one need not download these files (on demand) since they are already there.
In order to decide about the availability, the code checks for the presence of the relevant subdirectory of the other package.
And this check may happen during the time when AtlasRep gets loaded.

@fingolfin fingolfin merged commit e0343ca into gap-system:master Jan 14, 2021
@ThomasBreuer ThomasBreuer deleted the TB_DirectoriesPackage branch January 14, 2021 08:22
@ThomasBreuer ThomasBreuer self-assigned this Feb 16, 2021
@ThomasBreuer ThomasBreuer changed the title fix DirectoriesPackageLibrary/Programs Fixed DirectoriesPackageLibrary, DirectoriesPackagePrograms when they are called during package loading. Feb 16, 2021
@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@ThomasBreuer ThomasBreuer removed their assignment Feb 16, 2021
@fingolfin fingolfin changed the title Fixed DirectoriesPackageLibrary, DirectoriesPackagePrograms when they are called during package loading. Fix DirectoriesPackageLibrary, DirectoriesPackagePrograms when they are called during package loading Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: packages issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants