-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a PrintObj
method for general domains which know their GeneratorsOfDomain
#3468
Add a PrintObj
method for general domains which know their GeneratorsOfDomain
#3468
Conversation
PrintObj
method for general domains which know their GeneratorsOfDomain
This looks reasonable -- the failing tests is because the manual needs adjusting to the new nicer output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in principle, but of course the tests need to pass.
Ah, there were tests in the manuals that I missed. I'll have a look. |
4e7b04c
to
5ff0890
Compare
Updated. It should work now. |
Codecov Report
@@ Coverage Diff @@
## master #3468 +/- ##
==========================================
+ Coverage 85.34% 85.34% +<.01%
==========================================
Files 699 699
Lines 346483 346487 +4
==========================================
+ Hits 295711 295720 +9
+ Misses 50772 50767 -5
|
5ff0890
to
eab26ea
Compare
... which know their GeneratorsOfDomain. Adds tests and updates examples in the manual.
eab26ea
to
af56913
Compare
Supersedes #3460.
This enables nicer printing of mappings between sets: