Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PrintObj method for general domains which know their GeneratorsOfDomain #3468

Conversation

ssiccha
Copy link
Contributor

@ssiccha ssiccha commented May 21, 2019

Supersedes #3460.

This enables nicer printing of mappings between sets:

gap> MappingByFunction(Domain([1..5]), Domain([1..5]), x -> x);
MappingByFunction( Domain([ 1 .. 5 ]), Domain([ 1 .. 5 ]), function( x ) ... end )

@ssiccha ssiccha added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels May 21, 2019
@ssiccha ssiccha requested a review from fingolfin May 21, 2019 13:40
@ssiccha ssiccha changed the title lib: add PrintObj method for general domains ... Add a PrintObj method for general domains which know their GeneratorsOfDomain May 21, 2019
@ChrisJefferson
Copy link
Contributor

This looks reasonable -- the failing tests is because the manual needs adjusting to the new nicer output.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in principle, but of course the tests need to pass.

lib/domain.gi Outdated Show resolved Hide resolved
lib/domain.gi Outdated Show resolved Hide resolved
@ssiccha
Copy link
Contributor Author

ssiccha commented May 22, 2019

Ah, there were tests in the manuals that I missed. I'll have a look.

@ssiccha ssiccha force-pushed the ss/add-PrintObj-method-for-general-domains branch from 4e7b04c to 5ff0890 Compare May 22, 2019 12:50
@ssiccha
Copy link
Contributor Author

ssiccha commented May 22, 2019

Updated. It should work now.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #3468 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3468      +/-   ##
==========================================
+ Coverage   85.34%   85.34%   +<.01%     
==========================================
  Files         699      699              
  Lines      346483   346487       +4     
==========================================
+ Hits       295711   295720       +9     
+ Misses      50772    50767       -5
Impacted Files Coverage Δ
lib/relation.gd 100% <ø> (ø) ⬆️
lib/domain.gi 90.5% <100%> (+2.8%) ⬆️
src/stats.c 95.17% <0%> (-0.01%) ⬇️

@coveralls
Copy link

coveralls commented May 23, 2019

Coverage Status

Coverage increased (+0.002%) to 85.169% when pulling af56913 on ssiccha:ss/add-PrintObj-method-for-general-domains into 4437e09 on gap-system:master.

lib/domain.gi Outdated Show resolved Hide resolved
@ssiccha ssiccha force-pushed the ss/add-PrintObj-method-for-general-domains branch from 5ff0890 to eab26ea Compare May 25, 2019 12:33
... which know their GeneratorsOfDomain.

Adds tests and updates examples in the manual.
@ssiccha ssiccha force-pushed the ss/add-PrintObj-method-for-general-domains branch from eab26ea to af56913 Compare May 26, 2019 13:58
@fingolfin fingolfin merged commit a3a116c into gap-system:master May 28, 2019
@ssiccha ssiccha deleted the ss/add-PrintObj-method-for-general-domains branch August 7, 2019 08:47
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 21, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants