Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug in 64Bit SetCyclotomicsLimit #3390

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fix Bug in 64Bit SetCyclotomicsLimit #3390

merged 1 commit into from
Apr 3, 2019

Conversation

DominikBernhardt
Copy link
Contributor

Fixes #3389.

@DominikBernhardt DominikBernhardt added the kind: bug Issues describing general bugs, and PRs fixing them label Apr 2, 2019
@DominikBernhardt DominikBernhardt added this to the GAP 4.11 milestone Apr 2, 2019
@DominikBernhardt DominikBernhardt changed the title Fixes 64Bit Cyclotomic Size limit Fixes Bug in 64Bit SetCyclotomicsLimit Apr 2, 2019
@coveralls
Copy link

coveralls commented Apr 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.0006%) to 85.154% when pulling 35d12ee on DominikBernhardt:CyclotomicsLimit into 0ef46dc on gap-system:master.

@codecov
Copy link

codecov bot commented Apr 2, 2019 •
edited
Loading

Codecov Report

Merging #3390 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3390      +/-   ##
==========================================
- Coverage   85.15%   85.14%   -0.02%     
==========================================
  Files         697      696       -1     
  Lines      344073   343769     -304     
==========================================
- Hits       292995   292692     -303     
+ Misses      51078    51077       -1
Impacted Files Coverage Δ
src/cyclotom.c 92.98% <100%> (-0.12%) ⬇️
src/vector.c 94.8% <0%> (-2.77%) ⬇️
src/system.c 70.88% <0%> (-2.62%) ⬇️
src/objset.c 80.32% <0%> (-1.61%) ⬇️
src/listoper.c 78.28% <0%> (-0.55%) ⬇️
src/gap.c 79.62% <0%> (-0.45%) ⬇️
lib/init.g 83.11% <0%> (-0.37%) ⬇️
src/calls.c 93.24% <0%> (-0.34%) ⬇️
src/intfuncs.c 94.96% <0%> (-0.32%) ⬇️
src/dteval.c 81.08% <0%> (-0.26%) ⬇️
... and 6 more

fingolfin
fingolfin approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see if tests pass now before merging it

@wilfwilson wilfwilson added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 2, 2019
Fix 64Bit Cyclotomic Size limit
35d12ee 
Add test case for 2^32

Adjust test for 32bit systems
@DominikBernhardt DominikBernhardt changed the title Fixes Bug in 64Bit SetCyclotomicsLimit Fix Bug in 64Bit SetCyclotomicsLimit Apr 2, 2019
@fingolfin fingolfin merged commit 6f1661e into gap-system:master Apr 3, 2019
@DominikBernhardt DominikBernhardt deleted the CyclotomicsLimit branch April 14, 2019 19:04
@DominikBernhardt DominikBernhardt added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

@sebasguts sebasguts sebasguts approved these changes

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.

Bug in SetCyclotomicsLimit
5 participants
@DominikBernhardt @coveralls @fingolfin @sebasguts @wilfwilson