Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsys: add make check #3285

Merged
merged 1 commit into from
Feb 15, 2019
Merged

buildsys: add make check #3285

merged 1 commit into from
Feb 15, 2019

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Feb 12, 2019 •
edited
Loading

People familiar with automake based build systems expect this to work, and it also saves me some typing ;-)

Resolves #1439

I'd like to backport this to 4.10, too.

@fingolfin
buildsys: add make check
ccaebf8 
People familiar with automake based build systems expect this to work,
and it also saves me some typing ;-)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.069% when pulling ccaebf8 on fingolfin:mh/check into efcb6c5 on gap-system:master.

@fingolfin fingolfin mentioned this pull request Feb 13, 2019
Closed
@olexandr-konovalov
Copy link
Member

@fingolfin Do you want to add some command line options, like -r -A?

@fingolfin fingolfin added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Feb 14, 2019
@fingolfin
Copy link
Member Author

@alex-konovalov TESTGAP already contains -r -A

@fingolfin fingolfin merged commit d4f1d53 into gap-system:master Feb 15, 2019
@fingolfin fingolfin deleted the mh/check branch February 15, 2019 10:13
@fingolfin
Copy link
Member Author

Backported to 4.10 in eef7f99

@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.1 milestone Feb 23, 2019
@olexandr-konovalov olexandr-konovalov added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 23, 2019
@fingolfin fingolfin removed this from the GAP 4.10.1 milestone Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

@olexandr-konovalov olexandr-konovalov Awaiting requested review from olexandr-konovalov

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
backport-to-4.10-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes topic: build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "make check" target
4 participants
@fingolfin @coveralls @olexandr-konovalov @wilfwilson