generalized CharacterTableIsoclinic
#3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
added
kind: enhancement
Up to now, `CharacterTableIsoclinic` dealt only with character tables of groups of the structure 2.G.2 or 4.G.2. Now also the cases p.G.p, for odd primes p, are supported.
ThomasBreuer
force-pushed
the
TB_CharacterTableIsoclinic
branch
from
f49a5ee
to
111ea46
Compare
Codecov Report
@@ Coverage Diff @@
## master #3253 +/- ##
==========================================
+ Coverage 85.15% 85.15% +<.01%
==========================================
Files 694 696 +2
Lines 342306 344252 +1946
==========================================
+ Hits 291486 293144 +1658
- Misses 50820 51108 +288
|
|
@ThomasBreuer could you please use the "Rebase and merge" function when you merge your own PRs? |
|
@fingolfin Thanks for the hint. |
|
Once you used "Rebase and merge", that is the default (for you). I don't know whether we could set a default on the repository |
|
@fingolfin we could just disable merge commits on the repository. |
ThomasBreuer
added a commit
to ThomasBreuer/gap
that referenced
this pull request
Jul 17, 2019
The changes from pull request gap-system#3253 had the effect that the orderings of characters and classes in the result of `CharacterTableIsoclinic` were different from those in released versions of GAP. With the current change, we return to the previous orderings.
ThomasBreuer
added a commit
that referenced
this pull request
Jul 18, 2019
The changes from pull request #3253 had the effect that the orderings of characters and classes in the result of `CharacterTableIsoclinic` were different from those in released versions of GAP. With the current change, we return to the previous orderings.
DominikBernhardt
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now,
CharacterTableIsoclinicdealt only with character tablesof groups of the structure 2.G.2 or 4.G.2.
Now also the cases p.G.p, for odd primes p, are supported.