-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify a julia binary instead of a julia prefix #3243
Specify a julia binary instead of a julia prefix #3243
Conversation
This breaks all existing users of --with-julia, and also will complicate bisecting. At the very least, it'd be nice if we supported both giving a prefix or an executable path. Ah, this remonds me: I think gc=julia should imply --with-julia. Not a request for this PR, it just should be done eventually |
Codecov Report
@@ Coverage Diff @@
## master #3243 +/- ##
==========================================
- Coverage 85.09% 77.16% -7.94%
==========================================
Files 695 688 -7
Lines 344336 338935 -5401
==========================================
- Hits 293024 261524 -31500
- Misses 51312 77411 +26099
|
@fingolfin I thought about making this backwards-compatible, but I decided against because I wanted to set a default.
|
c8a4088
to
fae156e
Compare
and let julia collect the information about all other paths
fae156e
to
29e0c60
Compare
Backported to stable-4.10 in 3c74918 |
[],[with_julia=no] | ||
) | ||
[AS_HELP_STRING([--with-julia@<:@=PATH@:>@], | ||
[specify a prefix for a julia binary or a julia binary])], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebasguts do you really mean [specify a prefix for a julia binary or a julia binary]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean it that way.
You can either directly specify a julia binary, or its prefix, e.g., /usr/local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now I got it. Parsing plain text without parentheses or commas failed. Maybe
specify a prefix for a julia binary, or a julia binary
or
specify a julia binary or a prefix for a julia binary
would be easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I understand the problem now, sorry. I will provide a PR for that.
See also #3316 for an updated comment. |
and let julia collect the information about all other paths