Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functions GetChar and CharValue to libgap api #2999

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

sebasguts
Copy link
Member

No description provided.

Copy link
Contributor

@ChrisJefferson ChrisJefferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments. Feel free to ignore both of them!

src/libgap-api.c Show resolved Hide resolved
src/libgap-api.c Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
src/libgap-api.h Outdated Show resolved Hide resolved
src/libgap-api.c Outdated Show resolved Hide resolved
@fingolfin fingolfin added topic: kernel topic: libgap things related to libgap labels Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2999 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2999      +/-   ##
==========================================
- Coverage   85.13%   85.12%   -0.02%     
==========================================
  Files         110      110              
  Lines       56960    56966       +6     
==========================================
- Hits        48491    48490       -1     
- Misses       8469     8476       +7
Impacted Files Coverage Δ
src/libgap-api.c 25.51% <0%> (-1.67%) ⬇️
src/iostream.c 62.35% <0%> (-1.15%) ⬇️
src/hpc/threadapi.c 45.19% <0%> (+0.17%) ⬆️

@fingolfin
Copy link
Member

@ChrisJefferson are you OK with this now?

@ChrisJefferson
Copy link
Contributor

yup, happy

@markuspf markuspf merged commit 41cf327 into gap-system:master Nov 15, 2018
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Apr 15, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes topic: kernel topic: libgap things related to libgap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants