-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate PackageInfo.g when loading packages #2726
Merged
olexandr-konovalov
merged 1 commit into
gap-system:master
from
fingolfin:mh/LoadPackageValidation
Sep 7, 2018
Merged
Validate PackageInfo.g when loading packages #2726
olexandr-konovalov
merged 1 commit into
gap-system:master
from
fingolfin:mh/LoadPackageValidation
Sep 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
Label for issues suggesting enhancements; and for pull requests implementing enhancements
topic: packages
issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
topic: library
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
labels
Aug 22, 2018
Nice - from the packages redistributed with GAP, there is only one that triggers a warning:
because its date is |
Codecov Report
@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
- Coverage 76.37% 75.88% -0.49%
==========================================
Files 431 481 +50
Lines 220298 241315 +21017
==========================================
+ Hits 168251 183123 +14872
- Misses 52047 58192 +6145
|
@fingolfin can you rebase, and I will be happy to approve this? |
This helps package authors notice earlier if a package update they made failed.
fingolfin
force-pushed
the
mh/LoadPackageValidation
branch
from
September 7, 2018 08:02
1ed9ab1
to
811329b
Compare
Rebased. |
olexandr-konovalov
approved these changes
Sep 7, 2018
fingolfin
added
release notes: added
PRs introducing changes that have since been mentioned in the release notes
and removed
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
labels
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: enhancement
Label for issues suggesting enhancements; and for pull requests implementing enhancements
release notes: added
PRs introducing changes that have since been mentioned in the release notes
topic: library
topic: packages
issues or PRs related to package handling, or specific to a package (for packages w/o issue tracker)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps package authors notice earlier if a package update they made failed.
One could also be more aggressive and validate every package record as we load it; but I have far too many packages which are not validating sitting around (e.g. undeposited ones from gap-packages)