Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning a file given to Test contains no tests #2524

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

ChrisJefferson
Copy link
Contributor

This adds a simple warning when a test file is run which doesn't contain any tests. This is most common because someone has misformatted their test file.

Also add some very simple tests for Test. None of these tests check for failures, because failures contain the full path of the failing test, which will change depending on where GAP is installed.

@codecov
Copy link

codecov bot commented Jun 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@544e716). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #2524   +/-   ##
=========================================
  Coverage          ?   74.32%           
=========================================
  Files             ?      479           
  Lines             ?   238474           
  Branches          ?        0           
=========================================
  Hits              ?   177246           
  Misses            ?    61228           
  Partials          ?        0
Impacted Files Coverage Δ
lib/test.gi 65.48% <100%> (ø)

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should be rebased to make sure there is no conflict with #2519

@markuspf markuspf merged commit 758a719 into gap-system:master Jun 7, 2018
@markuspf
Copy link
Member

markuspf commented Jun 7, 2018

Gna. Sorry I thought the tests had passed just now. I hope it didn't break :/

@olexandr-konovalov olexandr-konovalov added the gapdays2018-spring Issues and PRs that arose at http://www.gapdays.de/gap-jupyter-days2018 label Jun 8, 2018
@ChrisJefferson ChrisJefferson deleted the test-warning branch June 11, 2018 19:02
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2018-spring Issues and PRs that arose at http://www.gapdays.de/gap-jupyter-days2018 release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants