Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trans: resolve GC bug Issue 2319 #2321

Merged
merged 1 commit into from
Mar 28, 2018
Merged

trans: resolve GC bug Issue 2319 #2321

merged 1 commit into from
Mar 28, 2018

Conversation

james-d-mitchell
Copy link
Contributor

@james-d-mitchell james-d-mitchell commented Mar 28, 2018 •
edited by fingolfin
Loading

Resolves #2319

@fingolfin
Copy link
Member

@james-d-mitchell Thanks! One minor request: If possible, I'd appreciate if you could please put "Resolves #XY" in the description body instead of (or in addition to) the subject line next time, so that the issues automatically gets closed when the PR is merged. I did it for you (well, or rather, for us, I guess ;-) this time.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) labels Mar 28, 2018
@fingolfin
Copy link
Member

@ChrisJefferson actually, I don't think we should mark these GC fixes as "not for release notes". Instead, I'll add a single entry a la "fixed lots of potential GC related crashes", referencing the PRs

@james-d-mitchell
Copy link
Contributor Author

@fingolfin Will do!

@fingolfin
Copy link
Member

Reminder to self re release notes: of course for fixes we backport, we should add them to the GAP 4.9 release notes, not 4.10

@fingolfin fingolfin added this to the GAP 4.9.1 milestone Mar 28, 2018
@fingolfin fingolfin merged commit 67ae392 into gap-system:master Mar 28, 2018
@fingolfin
Copy link
Member

Backported to stable-4.9 via ae5aa31

@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@james-d-mitchell @fingolfin @ChrisJefferson