Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn hidden implications into actual implications #2222

Merged
merged 8 commits into from
May 29, 2018
Merged

Turn hidden implications into actual implications #2222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d1e8f9
Add true implications for modules
fingolfin May 29, 2018
1557e2e
Add true implications for groups
fingolfin May 29, 2018
bd227c4
Add true implications for semigroups
fingolfin May 29, 2018
e98c7a2
Add true implications for pcgs
fingolfin May 29, 2018
45ac428
Add miscellaneous true implications
fingolfin May 29, 2018
3a3a6b5
Don't rely on hidden impls in certain method installations
fingolfin May 29, 2018
10ad299
Use IsListOrCollection instead of IsCollection in declarations
fingolfin May 29, 2018
7c8aec8
Update ShowImpliedFilters documentation
fingolfin May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hpcgap/lib/basis.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ DeclareSynonym( "IsFiniteBasisDefault",
## <#/GAPDoc>
##
DeclareProperty( "IsCanonicalBasis", IsBasis );
InstallTrueMethod( IsBasis, IsCanonicalBasis );


#############################################################################
Expand Down
2 changes: 2 additions & 0 deletions lib/algrep.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ DeclareCategoryCollections( "IsRightAlgebraModuleElement" );
## </ManSection>
##
DeclareProperty( "IsAlgebraModule", IsLeftModule );
InstallTrueMethod( IsLeftModule, IsAlgebraModule );

##############################################################################
##
Expand All @@ -157,6 +158,7 @@ DeclareProperty( "IsAlgebraModule", IsLeftModule );
## </ManSection>
##
DeclareProperty( "IsLeftAlgebraModule", IsLeftModule );
InstallTrueMethod( IsLeftModule, IsLeftAlgebraModule );

##############################################################################
##
Expand Down
1 change: 1 addition & 0 deletions lib/basis.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ DeclareSynonym( "IsFiniteBasisDefault",
## <#/GAPDoc>
##
DeclareProperty( "IsCanonicalBasis", IsBasis );
InstallTrueMethod( IsBasis, IsCanonicalBasis );


#############################################################################
Expand Down
2 changes: 1 addition & 1 deletion lib/coll.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,7 +1395,7 @@ DeclareProperty( "IsNonTrivial", IsCollection );
## </ManSection>
## <#/GAPDoc>
##
DeclareProperty( "IsFinite", IsCollection );
DeclareProperty( "IsFinite", IsListOrCollection );

InstallSubsetMaintenance( IsFinite,
IsCollection and IsFinite, IsCollection );
Expand Down
3 changes: 2 additions & 1 deletion lib/ctblfuns.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,7 @@ DeclareOperation( "IsCharacter", [ IsCharacterTable, IsHomogeneousList ] );
## <#/GAPDoc>
##
DeclareProperty( "IsVirtualCharacter", IsClassFunction );
InstallTrueMethod( IsClassFunction, IsVirtualCharacter );
DeclareOperation( "IsVirtualCharacter",
[ IsCharacterTable, IsHomogeneousList ] );

Expand All @@ -1150,7 +1151,7 @@ DeclareOperation( "IsVirtualCharacter",
##
## Each character is of course a virtual character.
##
InstallTrueMethod( IsVirtualCharacter, IsCharacter and IsClassFunction );
InstallTrueMethod( IsVirtualCharacter, IsCharacter );


#############################################################################
Expand Down
1 change: 1 addition & 0 deletions lib/field.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ DeclareAttribute( "PrimeField", IsDivisionRing );
## <#/GAPDoc>
##
DeclareProperty( "IsPrimeField", IsDivisionRing );
InstallTrueMethod( IsField, IsPrimeField );

InstallIsomorphismMaintenance( IsPrimeField,
IsField and IsPrimeField, IsField );
Expand Down
1 change: 1 addition & 0 deletions lib/fldabnum.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
## <#/GAPDoc>
##
DeclareProperty( "IsNumberField", IsField );
InstallTrueMethod( IsField, IsNumberField );

InstallSubsetMaintenance( IsNumberField,
IsField and IsNumberField, IsField );
Expand Down
3 changes: 2 additions & 1 deletion lib/ghom.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,14 +266,15 @@ DeclareAttribute( "AsGroupGeneralMappingByImages", IsGroupGeneralMapping );
## </ManSection>
##
DeclareAttribute( "MappingOfWhichItIsAsGGMBI", IsGroupGeneralMapping );
InstallTrueMethod( IsGroupGeneralMapping, MappingOfWhichItIsAsGGMBI );

InstallAttributeMethodByGroupGeneralMappingByImages :=
function( attr, value_filter )
InstallMethod( attr, "via `AsGroupGeneralMappingByImages'", true,
[ IsGroupGeneralMappingByAsGroupGeneralMappingByImages ], 0,
hom -> attr( AsGroupGeneralMappingByImages( hom ) ) );
InstallMethod( attr, "get delayed set attribute values", true,
[ HasMappingOfWhichItIsAsGGMBI ],
[ IsGroupGeneralMapping and HasMappingOfWhichItIsAsGGMBI ],
SUM_FLAGS-1, # we want to do this before doing any calculations
function(hom)
hom:=MappingOfWhichItIsAsGGMBI( hom );
Expand Down
4 changes: 4 additions & 0 deletions lib/gpprmsya.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@
## <#/GAPDoc>
##
DeclareProperty( "IsNaturalSymmetricGroup", IsPermGroup );
InstallTrueMethod( IsPermGroup, IsNaturalSymmetricGroup );

DeclareProperty( "IsNaturalAlternatingGroup", IsPermGroup );
InstallTrueMethod( IsPermGroup, IsNaturalAlternatingGroup );


#############################################################################
Expand All @@ -66,6 +68,7 @@ DeclareProperty( "IsNaturalAlternatingGroup", IsPermGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsAlternatingGroup", IsGroup );
InstallTrueMethod( IsGroup, IsAlternatingGroup );


#############################################################################
Expand All @@ -91,6 +94,7 @@ InstallTrueMethod( IsAlternatingGroup, IsNaturalAlternatingGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsSymmetricGroup", IsGroup );
InstallTrueMethod( IsGroup, IsSymmetricGroup );


#############################################################################
Expand Down
22 changes: 15 additions & 7 deletions lib/grp.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ InstallTrueMethod( IsCommutative, IsGroup and IsElementaryAbelian );
## <#/GAPDoc>
##
DeclareProperty( "IsFinitelyGeneratedGroup", IsGroup );
InstallTrueMethod( IsGroup, IsFinitelyGeneratedGroup );

InstallFactorMaintenance( IsFinitelyGeneratedGroup,
IsGroup and IsFinitelyGeneratedGroup, IsObject, IsGroup );
Expand Down Expand Up @@ -433,6 +434,7 @@ DeclareOperation( "KnowsHowToDecompose", [ IsGroup, IsList ] );
## <#/GAPDoc>
##
DeclareProperty( "IsPGroup", IsGroup );
InstallTrueMethod( IsGroup, IsPGroup );

InstallSubsetMaintenance( IsPGroup,
IsGroup and IsPGroup, IsGroup );
Expand Down Expand Up @@ -468,6 +470,7 @@ InstallTrueMethod( IsPGroup, IsGroup and IsElementaryAbelian );
## <#/GAPDoc>
##
DeclareProperty( "IsPowerfulPGroup", IsGroup );
InstallTrueMethod( IsPGroup, IsPowerfulPGroup );

#Quotients of powerful of powerful p groups are powerful
InstallFactorMaintenance( IsPowerfulPGroup,
Expand Down Expand Up @@ -567,6 +570,7 @@ DeclareAttribute( "RankPGroup", IsPGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsNilpotentGroup", IsGroup );
InstallTrueMethod( IsGroup, IsNilpotentGroup );

InstallSubsetMaintenance( IsNilpotentGroup,
IsGroup and IsNilpotentGroup, IsGroup );
Expand All @@ -578,7 +582,6 @@ InstallTrueMethod( IsNilpotentGroup, IsGroup and IsCommutative );

InstallTrueMethod( IsNilpotentGroup, IsGroup and IsPGroup and IsFinite );


#############################################################################
##
#P IsPerfectGroup( <G> )
Expand All @@ -595,11 +598,11 @@ InstallTrueMethod( IsNilpotentGroup, IsGroup and IsPGroup and IsFinite );
## <#/GAPDoc>
##
DeclareProperty( "IsPerfectGroup", IsGroup );
InstallTrueMethod( IsGroup, IsPerfectGroup );

InstallFactorMaintenance( IsPerfectGroup,
IsGroup and IsPerfectGroup, IsObject, IsGroup );


#############################################################################
##
#P IsSporadicSimpleGroup( <G> )
Expand All @@ -624,11 +627,11 @@ InstallFactorMaintenance( IsPerfectGroup,
## </ManSection>
##
DeclareProperty( "IsSporadicSimpleGroup", IsGroup );
InstallTrueMethod( IsGroup, IsSporadicSimpleGroup );

InstallIsomorphismMaintenance( IsSporadicSimpleGroup,
IsGroup and IsSporadicSimpleGroup, IsGroup );


#############################################################################
##
#P IsSimpleGroup( <G> )
Expand All @@ -645,12 +648,12 @@ InstallIsomorphismMaintenance( IsSporadicSimpleGroup,
## <#/GAPDoc>
##
DeclareProperty( "IsSimpleGroup", IsGroup );
InstallTrueMethod( IsGroup, IsSimpleGroup );

InstallIsomorphismMaintenance( IsSimpleGroup,
IsGroup and IsSimpleGroup, IsGroup );

InstallTrueMethod( IsSimpleGroup, IsGroup and IsSporadicSimpleGroup );

InstallTrueMethod( IsSimpleGroup, IsSporadicSimpleGroup );

#############################################################################
##
Expand Down Expand Up @@ -703,6 +706,7 @@ InstallTrueMethod( IsSimpleGroup, IsGroup and IsSporadicSimpleGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsAlmostSimpleGroup", IsGroup );
InstallTrueMethod( IsGroup, IsAlmostSimpleGroup );


#############################################################################
Expand All @@ -721,6 +725,7 @@ DeclareProperty( "IsAlmostSimpleGroup", IsGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsSupersolvableGroup", IsGroup );
InstallTrueMethod( IsGroup, IsSupersolvableGroup );

InstallSubsetMaintenance( IsSupersolvableGroup,
IsGroup and IsSupersolvableGroup, IsGroup );
Expand All @@ -747,6 +752,7 @@ InstallTrueMethod( IsSupersolvableGroup, IsNilpotentGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsMonomialGroup", IsGroup );
InstallTrueMethod( IsGroup, IsMonomialGroup );

InstallFactorMaintenance( IsMonomialGroup,
IsGroup and IsMonomialGroup, IsObject, IsGroup );
Expand Down Expand Up @@ -776,6 +782,7 @@ InstallTrueMethod( IsMonomialGroup, IsSupersolvableGroup and IsFinite );
## <#/GAPDoc>
##
DeclareProperty( "IsSolvableGroup", IsGroup );
InstallTrueMethod( IsGroup, IsSolvableGroup );

InstallSubsetMaintenance( IsSolvableGroup,
IsGroup and IsSolvableGroup, IsGroup );
Expand Down Expand Up @@ -808,6 +815,7 @@ InstallTrueMethod( IsSolvableGroup, IsSupersolvableGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsPolycyclicGroup", IsGroup );
InstallTrueMethod( IsGroup, IsPolycyclicGroup );
InstallTrueMethod( IsSolvableGroup, IsPolycyclicGroup );
InstallTrueMethod( IsPolycyclicGroup, IsSolvableGroup and IsFinite );
InstallTrueMethod( IsPolycyclicGroup,
Expand Down Expand Up @@ -3547,7 +3555,7 @@ DeclareOperation( "GrowthFunctionOfGroup",
##
DeclareOperation( "GroupByGenerators", [ IsCollection ] );
DeclareOperation( "GroupByGenerators",
[ IsCollection, IsMultiplicativeElementWithInverse ] );
[ IsListOrCollection, IsMultiplicativeElementWithInverse ] );


#############################################################################
Expand All @@ -3571,7 +3579,7 @@ DeclareOperation( "GroupByGenerators",
##
DeclareOperation( "GroupWithGenerators", [ IsCollection ] );
DeclareOperation( "GroupWithGenerators",
[ IsCollection, IsMultiplicativeElementWithInverse ] );
[ IsListOrCollection, IsMultiplicativeElementWithInverse ] );


#############################################################################
Expand Down
6 changes: 6 additions & 0 deletions lib/grpmat.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ DeclareGlobalFunction("NaturalActedSpace");
DeclareProperty( "IsGeneralLinearGroup", IsGroup );
DeclareSynonymAttr( "IsGL", IsGeneralLinearGroup );

InstallTrueMethod( IsGroup, IsGeneralLinearGroup );


#############################################################################
##
Expand Down Expand Up @@ -264,6 +266,7 @@ InstallTrueMethod(IsGeneralLinearGroup,IsNaturalGL);
DeclareProperty( "IsSpecialLinearGroup", IsGroup );
DeclareSynonymAttr( "IsSL", IsSpecialLinearGroup );

InstallTrueMethod( IsGroup, IsSpecialLinearGroup );

#############################################################################
##
Expand Down Expand Up @@ -348,6 +351,7 @@ DeclareAttribute( "InvariantBilinearForm", IsMatrixGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsFullSubgroupGLorSLRespectingBilinearForm", IsMatrixGroup );
InstallTrueMethod( IsGroup, IsFullSubgroupGLorSLRespectingBilinearForm );


#############################################################################
Expand Down Expand Up @@ -396,6 +400,7 @@ DeclareAttribute( "InvariantSesquilinearForm", IsMatrixGroup );
##
DeclareProperty( "IsFullSubgroupGLorSLRespectingSesquilinearForm",
IsMatrixGroup );
InstallTrueMethod( IsGroup, IsFullSubgroupGLorSLRespectingSesquilinearForm );


#############################################################################
Expand Down Expand Up @@ -491,6 +496,7 @@ DeclareAttribute( "InvariantQuadraticForm", IsMatrixGroup );
##
DeclareProperty( "IsFullSubgroupGLorSLRespectingQuadraticForm",
IsMatrixGroup );
InstallTrueMethod( IsGroup, IsFullSubgroupGLorSLRespectingQuadraticForm );

#############################################################################
##
Expand Down
7 changes: 7 additions & 0 deletions lib/grpnames.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,8 @@ DeclareSynonym( "DecompositionTypes", DecompositionTypesOfGroup );
DeclareProperty( "IsDihedralGroup", IsGroup );
DeclareAttribute( "DihedralGenerators", IsGroup );

InstallTrueMethod( IsGroup, IsDihedralGroup );

#############################################################################
##
#P IsQuaternionGroup( <G> )
Expand All @@ -469,6 +471,8 @@ DeclareAttribute( "DihedralGenerators", IsGroup );
DeclareProperty( "IsQuaternionGroup", IsGroup );
DeclareAttribute( "QuaternionGenerators", IsGroup );

InstallTrueMethod( IsGroup, IsQuaternionGroup );

#############################################################################
##
#P IsQuasiDihedralGroup( <G> )
Expand All @@ -490,6 +494,8 @@ DeclareAttribute( "QuaternionGenerators", IsGroup );
DeclareProperty( "IsQuasiDihedralGroup", IsGroup );
DeclareAttribute( "QuasiDihedralGenerators", IsGroup );

InstallTrueMethod( IsGroup, IsQuasiDihedralGroup );

#############################################################################
##
#P IsPSL( <G> )
Expand All @@ -506,6 +512,7 @@ DeclareAttribute( "QuasiDihedralGenerators", IsGroup );
## </ManSection>
##
DeclareProperty( "IsPSL", IsGroup );
InstallTrueMethod( IsGroup, IsPSL );

#############################################################################
##
Expand Down
2 changes: 1 addition & 1 deletion lib/grppc.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ end);
#M Pcgs( <G> )
##
InstallMethod( Pcgs, "fail if not solvable", true,
[ HasIsSolvableGroup ],
[ IsGroup and HasIsSolvableGroup ],
SUM_FLAGS, # for groups for which we know that they are not solvable
# this is the best we can do.
function( G )
Expand Down
2 changes: 1 addition & 1 deletion lib/grppcatr.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ end);
#M GeneratorsSmallest(<pcgrp>)
##
InstallMethod(GeneratorsSmallest,"group of pc words which is full family",
true, [HasFamilyPcgs],0,
true, [IsGroup and HasFamilyPcgs],0,
function(G)
local pcgs,gens,U,e,i,j,pa,ros,smallpcgs,exp;

Expand Down
2 changes: 2 additions & 0 deletions lib/grpramat.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ DeclareSynonym( "IsCyclotomicMatrixGroup", IsCyclotomicCollCollColl and IsMatrix
## <#/GAPDoc>
##
DeclareProperty( "IsRationalMatrixGroup", IsCyclotomicMatrixGroup );
InstallTrueMethod( IsCyclotomicMatrixGroup, IsRationalMatrixGroup );

#############################################################################
##
Expand All @@ -59,6 +60,7 @@ DeclareProperty( "IsRationalMatrixGroup", IsCyclotomicMatrixGroup );
## <#/GAPDoc>
##
DeclareProperty( "IsIntegerMatrixGroup", IsCyclotomicMatrixGroup );
InstallTrueMethod( IsRationalMatrixGroup, IsIntegerMatrixGroup );

#############################################################################
##
Expand Down
6 changes: 3 additions & 3 deletions lib/ideal.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ InstallTrueMethod( IsTwoSidedIdealInParent,
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "TwoSidedIdealByGenerators", [ IsRing, IsCollection ] );
DeclareOperation( "TwoSidedIdealByGenerators", [ IsRing, IsListOrCollection ] );

DeclareSynonym( "IdealByGenerators", TwoSidedIdealByGenerators );

Expand All @@ -252,7 +252,7 @@ DeclareSynonym( "IdealByGenerators", TwoSidedIdealByGenerators );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "LeftIdealByGenerators", [ IsRing, IsCollection ] );
DeclareOperation( "LeftIdealByGenerators", [ IsRing, IsListOrCollection ] );


#############################################################################
Expand All @@ -275,7 +275,7 @@ DeclareOperation( "LeftIdealByGenerators", [ IsRing, IsCollection ] );
## </ManSection>
## <#/GAPDoc>
##
DeclareOperation( "RightIdealByGenerators", [ IsRing, IsCollection ] );
DeclareOperation( "RightIdealByGenerators", [ IsRing, IsListOrCollection ] );


#############################################################################
Expand Down
Loading