Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shortname to IsomorphismTypeInfoFiniteSimpleGroup value #2136

Conversation

ThomasBreuer
Copy link
Contributor

The record returned by IsomorphismTypeInfoFiniteSimpleGroup
contains a name component that is not suitable for
programmatic access.

The new component shortname fits to the names that are used in
CTblLib and AtlasRep.
It will simplify some of my example sessions.
In particular I will be able to get rid of some calls to
StructureDescription; I think it is not appropriate to advertise
that function by applying it to simple groups.

TB

The record returned by `IsomorphismTypeInfoFiniteSimpleGroup`
contains a `name` component that is not suitable for
programmatic access.

The new component `shortname` fits to the names that are used in
`CTblLib` and `AtlasRep`.
It will simplify some of my example sessions.
In particular I will be able to get rid of some calls to
`StructureDescription`; I think it is not appropriate to advertise
that function by applying it to simple groups.

    TB
@hulpke
Copy link
Contributor

hulpke commented Jan 31, 2018

Let me just note that there also is now DataAboutSimpleGroup which includes the IsomorphismType record, but also easier parseable information about the group. It is used currently in subgroup lattice and automorphism group calculations for almost simple groups, and has a component tomName which seems to be the same as shortname.

@ThomasBreuer
Copy link
Contributor Author

@hulpke: Interesting, thanks for the hint.
DataAboutSimpleGroup seems to be undocumented.
I think IsomorphismTypeInfoFiniteSimpleGroup is a more suitable place for what I call shortname,
this function is applicable also to character tables and positive integers (documented).

Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful functionality that should have been available long ago.

@fingolfin fingolfin merged commit f004681 into gap-system:master Feb 4, 2018
@olexandr-konovalov
Copy link
Member

olexandr-konovalov commented Feb 4, 2018

Thanks - should this be mentioned in GAP 4.10 release notes then?

@ThomasBreuer
Copy link
Contributor Author

@alex-konovalov:
I am not sure about the release notes.
On the one hand, I hope that this small change does not belong to the "most important" ones.
On the other hand, where would someone find a remark about the new record component?

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label May 2, 2018
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 20, 2018
@ThomasBreuer ThomasBreuer deleted the TB_IsomorphismTypeInfoFiniteSimpleGroup branch July 8, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants