Make permutations remember their inverses (cleanup of #1772) #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For permutations whose degree is less than PERM_INVERSE_THRESHOLD, QuoIntPerm2/4 compute and store the inverse
Taking the quotient of permutations x/y involves computing y^-1, which was previously stored in a temporary buffer and then discarded. Since we now remember inverses, just compute x*y^-1 which does essentially the same thing AND stores the inverse. It's also much shorter code.
fingolfin
added
kind: enhancement
Codecov Report
@@ Coverage Diff @@
## master #1831 +/- ##
==========================================
+ Coverage 50.44% 63.05% +12.6%
==========================================
Files 448 969 +521
Lines 234445 292732 +58287
Branches 10446 12912 +2466
==========================================
+ Hits 118268 184569 +66301
+ Misses 113385 105355 -8030
- Partials 2792 2808 +16
|
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleaned up version of PR #1772: I run clang-format on the changes, and split them cleanly into self-contained commits. Otherwise, it should be identical to that PR.