Fix EqFloat to actually work correctly #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
kind: bug
ChrisJefferson
approved these changes
May 30, 2017
tst/testinstall/float.tst
Outdated
| @@ -145,6 +145,10 @@ gap> -MakeFloat(1.0, infinity) = neginf; | |||
| true | |||
| gap> MakeFloat(1.0, -infinity) = neginf; | |||
| true | |||
| gap> EqFloat(1.0, 1.1); | |||
| false; | |||
There was a problem hiding this comment.
Random extra semicolon here
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
==========================================
- Coverage 61.78% 61.77% -0.01%
==========================================
Files 1034 1034
Lines 356652 356551 -101
Branches 14284 14250 -34
==========================================
- Hits 220345 220253 -92
- Misses 132654 132657 +3
+ Partials 3653 3641 -12
|
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
=======================================
Coverage 61.78% 61.78%
=======================================
Files 1034 1034
Lines 356652 356652
Branches 14284 14283 -1
=======================================
Hits 220345 220345
Misses 132654 132654
Partials 3653 3653
|
|
All OK, Thanks! |
|
@laurentbartholdi good point, done! |
markuspf
approved these changes
May 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always returned false for machine floats in the past, due to a missing argument.