Remove the timeout code #1324
Merged
Remove the timeout code #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
do not merge
fingolfin
removed
the
do not merge
Codecov Report
@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
- Coverage 62.64% 62.64% -0.01%
==========================================
Files 1015 1014 -1
Lines 342624 342352 -272
Branches 14218 14182 -36
==========================================
- Hits 214622 214450 -172
+ Misses 124855 124782 -73
+ Partials 3147 3120 -27
|
|
The AppVeyor failure was due to a hack we had in place that removed Also rebased this. |
|
Also note that @ChrisJefferson provided a well-working alternative for most use-cases based on |
ChrisJefferson
approved these changes
Jun 6, 2017
It had fundamental problems which seem unlikely to be resolved. See also issues gap-system#664, gap-system#695, gap-system#765.
This was referenced Jun 11, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It suffers from fundamental problems which seem unlikely to be resolved.
See also issues #664, #695, #765.
This should not be merged without discussion on the mailing list: After all, it removes a feature that was documented in a previous release. The only reason I am considering doing so at all is that I hope the feature is obscure enough that most people won't notice anyway.