Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests for group constructors and some fixes #1053

Merged
merged 14 commits into from
Jan 13, 2017
Merged

New tests for group constructors and some fixes #1053

merged 14 commits into from
Jan 13, 2017

Commits on Jan 7, 2017

  1. grp: remove trailing newlines from errors

    @fingolfin
    fingolfin committed Jan 7, 2017
    Configuration menu
    Copy the full SHA
    b5c00b8 View commit details
    Browse the repository at this point in the history

  2. tests: add tests for various group constructors

    @fingolfin
    fingolfin committed Jan 7, 2017
    Configuration menu
    Copy the full SHA
    2227604 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2017

  1. tests: construct all perfect groups

    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    1b56939 View commit details
    Browse the repository at this point in the history

  2. grp: fix GO(+1,4,5)

    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    cacf734 View commit details
    Browse the repository at this point in the history

  3. tests: verify forms of orthogonal and unitary groups

    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    2b1ea6f View commit details
    Browse the repository at this point in the history

  4. tests: move some fast tests from teststandard to testinstall 

    Also updated some comments explaining why certain tests are excluded
from testinstall.
    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    54ba846 View commit details
    Browse the repository at this point in the history

  5. tests: cover two more ReeGroup/SuzukiGroup error messages 

    These error message (and also those for the classical groups)
seem to vary quite a bit. We may want to unify them at some point.
    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    ba25a69 View commit details
    Browse the repository at this point in the history

  6. grp: don't invoke constructors with too many arguments 

    For some strange reasons, many group constructor wrapper allow the user
to pass one more argument than documented. I could not find any methods
supporting these extra arguments. Looking at the old repository, these
extra calls already appear in the first GAP4 version of this code, added
by Frank Celler 1997-01-15. So I think it's either a copy&paste mistake,
or a remnant of GAP3.
    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    fffc58a View commit details
    Browse the repository at this point in the history

  7. grp: correct FreeAbelianGroup error message

    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    f1c3f33 View commit details
    Browse the repository at this point in the history

  8. grp: remove extra space from error messages

    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    b504e59 View commit details
    Browse the repository at this point in the history

  9. tests: add tests for basic group constructors

    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    48acf38 View commit details
    Browse the repository at this point in the history

  10. grp: get rid of cache for perfect group data 

    The whole data is only about 4.5 MB in RAM. The implemented caching
logic was not very clever either (e.g. not using a "last recently used"
approach, but rather always throwing away the first 25 loaded PERFGRP
entries).
    @fingolfin
    fingolfin committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    901749c View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. grp: set invariant form for Sp(2n,Integers mod 2^k)

    @fingolfin
    fingolfin committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    30227dc View commit details
    Browse the repository at this point in the history

  2. tests: construct more Sp & SO over ZmodnZ, check forms

    @fingolfin
    fingolfin committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    3a85e11 View commit details
    Browse the repository at this point in the history