Tilde fix #1050
Closed
Tilde fix #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for functions of the form {x,y} -> result. This is
actually a very small change, most of the code churn is seperating
out function argument parsing so it can be used in both traditional
functions and lambda functions.
|
@ChrisJefferson there are some errors in the tests, according to Travis.. |
ChrisJefferson
force-pushed
the
tilde-fix
branch
from
e3650d1
to
04fb2ea
Compare
|
Bah, this is some different, old errors. (We leave |
ChrisJefferson
force-pushed
the
tilde-fix
branch
from
04fb2ea
to
0d0dcc1
Compare
|
Hopefully fixed after this patch filters through. |
Current coverage is 50.43% (diff: 87.40%)@@ master #1050 diff @@
==========================================
Files 424 424
Lines 223027 223041 +14
Methods 3429 3433 +4
Messages 0 0
Branches 0 0
==========================================
+ Hits 112445 112488 +43
+ Misses 110582 110553 -29
Partials 0 0
|
|
Rebased version is now in master as 51e8c0b |
|
I also tweaked two commit messages: One to reference issue #1049, the other for brevity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1049 (users can assign
~).This is built on top of #490, so that should be merged first (if that gets rejected, or edited, I will adjust this as appropriate).