Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DotFileLatticeSubgroups can't handle trivial group #663

Closed
ssiccha opened this issue Mar 8, 2016 · 5 comments
Closed

DotFileLatticeSubgroups can't handle trivial group #663

ssiccha opened this issue Mar 8, 2016 · 5 comments
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: bug Issues describing general bugs, and PRs fixing them
Milestone
GAP 4.8.3

Comments

@ssiccha
Copy link
Contributor

ssiccha commented Mar 8, 2016 

DotFileLatticeSubgroups( LatticeSubgroups( Group(()) ), "test" );

throws an error:

Error, MaximumList: <list> must contain at least one element called from
...
hulpke added a commit to hulpke/gap that referenced this issue Mar 8, 2016
@hulpke
FIX: MaximalSubgroupsLattice for trivial group
58051b3 
This fixes gap-system#663
hulpke added a commit to hulpke/gap that referenced this issue Mar 8, 2016
@hulpke
FIX: MaximalSubgroupsLattice for trivial group
ced352b 
This fixes gap-system#663
@ssiccha ssiccha closed this as completed Mar 9, 2016
@ssiccha ssiccha reopened this Mar 9, 2016
@markuspf
Copy link
Member

markuspf commented Mar 9, 2016

Nice catch!

Would you mind adding some code that handles this case and opening a pull request?

@markuspf markuspf added kind: bug Issues describing general bugs, and PRs fixing them good first issue Issues that can be understood and addressed by newcomers to GAP development labels Mar 9, 2016
@markuspf markuspf added this to the GAP 4.8.3 milestone Mar 9, 2016
@markuspf
Copy link
Member

markuspf commented Mar 9, 2016

Sorry I just saw that @hulpke already fixed this.

hulpke added a commit to hulpke/gap that referenced this issue Mar 9, 2016
@hulpke
FIX: MaximalSubgroupsLattice for trivial group
73bd80d 
This fixes gap-system#663
@ssiccha
Copy link
Contributor Author

ssiccha commented Mar 9, 2016

Yes, I figured it shouldn't be too hard to find the relevant code but Alexander beat me to it. ;)
Cheers

@olexandr-konovalov
Copy link
Member

This is marked for 4.8.3 but still waits a PR from @hulpke or should be postponed as non-critical.

@hulpke
Copy link
Contributor

hulpke commented Mar 11, 2016

This was part of PR #667 Thus closed.

@hulpke hulpke closed this as completed Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that can be understood and addressed by newcomers to GAP development kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Milestone
GAP 4.8.3
Development

No branches or pull requests
4 participants
@markuspf @olexandr-konovalov @hulpke @ssiccha