Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsomorphismGroups regression in 4.13.0 #5708

Closed
antonio-rojas opened this issue May 3, 2024 · 3 comments · Fixed by #5711
Closed

IsomorphismGroups regression in 4.13.0 #5708

antonio-rojas opened this issue May 3, 2024 · 3 comments · Fixed by #5711
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them

Comments

@antonio-rojas
Copy link

Observed behaviour

With 4.13.0 or current master:

gap> G:=Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)(13,15)(16,17) ]);
Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)
  (13,15)(16,17) ])
gap> H:=Group([ (1,2,3,4,5), (3,4,5), (6,7) ]);
Group([ (1,2,3,4,5), (3,4,5), (6,7) ])
gap> IsomorphismGroups(G,H);

Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `Representative' on 1 arguments
The 1st argument is 'fail' which might point to an earlier problem
 at /usr/share/gap/lib/methsel2.g:250 called from
Representative( of ) at /usr/share/gap/lib/morpheus.gi:538 called from
AssignNiceMonomorphismAutomorphismGroup( A, G ); at /usr/share/gap/lib/morpheus.gi:2565 called from
NiceMonomorphism( obj1 ) at /usr/share/gap/lib/grpnice.gi:313 called from
ClosureGroup( G, gen ) at /usr/share/gap/lib/grp.gi:2617 called from
ClosureGroup( G, obj ) at /usr/share/gap/lib/grp.gi:2644 called from
...  at *stdin*:3

Expected behaviour

With 4.12.2:

gap> G:=Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)(13,15)(16,17) ]);
Group([ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)
  (13,15)(16,17) ])
gap> H:=Group([ (1,2,3,4,5), (3,4,5), (6,7) ]);
Group([ (1,2,3,4,5), (3,4,5), (6,7) ])
gap> IsomorphismGroups(G,H);

[ (2,11,20)(3,10,19)(4,9,12)(5,8,13)(6,15,17)(7,14,18), (2,20)(3,4)(5,7)(8,18)(9,19)(10,12)(13,14)(15,17), (1,2)(3,20)(6,18)(7,19)(8,12)(9,11)(13,
    15)(16,17) ] -> [ (1,2,3), (1,3)(4,5)(6,7), (2,5)(3,4)(6,7) ]

Copy and paste GAP banner (to tell us about your setup)

 ┌───────┐   GAP 4.12.2 of 2022-12-18
 │  GAP  │   https://www.gap-system.org
 └───────┘   Architecture: x86_64-pc-linux-gnu-default64-kv8
 Configuration:  gmp 6.3.0, GASMAN, readline
 Loading the library and packages ...
 Packages:   Alnuth 3.2.1, AtlasRep 2.1.6, AutPGrp 1.11, CRISP 1.4.6, CTblLib 1.3.4, FactInt 1.6.3, FGA 1.4.0, GAPDoc 1.6.6, IRREDSOL 1.4.4, 
             LAGUNA 3.9.5, Polenta 1.3.10, Polycyclic 2.16, PrimGrp 3.4.3, RadiRoot 2.9, ResClasses 4.7.3, SmallGrp 1.5.1, Sophus 1.27, TomLib 1.2.9, 
             TransGrp 3.6.3, utils 0.81
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
@antonio-rojas
Copy link
Author

Caused by 58f31c6

@fingolfin fingolfin added regression A bug that only occurs in the branch, not in a release kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them and removed regression A bug that only occurs in the branch, not in a release labels May 4, 2024
@fingolfin
Copy link
Member

Thanks for the report @antonio-rojas we'll have a look

(Ping @hulpke)

hulpke added a commit to hulpke/gap that referenced this issue May 6, 2024
In rare cases, class representatives might all lie in existing group, but
other elts are outside. Cover this situation.
This fixes gap-system#5708
hulpke added a commit to hulpke/gap that referenced this issue May 6, 2024
In rare cases, class representatives might all lie in existing group, but
other elts are outside. Cover this situation.
This fixes gap-system#5708
@hulpke
Copy link
Contributor

hulpke commented May 6, 2024

Fixed (harmless bug, will only lead to error messages).

hulpke added a commit to hulpke/gap that referenced this issue May 6, 2024
In rare cases, class representatives might all lie in existing group, but
other elts are outside. Cover this situation.
This fixes gap-system#5708
hulpke added a commit to hulpke/gap that referenced this issue May 6, 2024
In rare cases, class representatives might all lie in existing group, but
other elts are outside. Cover this situation.
This fixes gap-system#5708
fingolfin pushed a commit to fingolfin/gap that referenced this issue May 6, 2024
In rare cases, class representatives might all lie in existing group, but
other elts are outside. Cover this situation.
This fixes gap-system#5708
@fingolfin fingolfin changed the title IsomorphismGroup regression in 4.13.0 IsomorphismGroups regression in 4.13.0 May 6, 2024
fingolfin pushed a commit that referenced this issue May 6, 2024
In rare cases, class representatives might all lie in existing group, but
other elts are outside. Cover this situation.
This fixes #5708
fingolfin pushed a commit that referenced this issue May 6, 2024
In rare cases, class representatives might all lie in existing group, but
other elts are outside. Cover this situation.
This fixes #5708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants