Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in GAP 4.13.0, concerning IsomorphismPermGroupOrFailFpGroup? #5697

Closed
ThomasBreuer opened this issue Apr 5, 2024 · 4 comments · Fixed by #5709
Closed

regression in GAP 4.13.0, concerning IsomorphismPermGroupOrFailFpGroup? #5697

ThomasBreuer opened this issue Apr 5, 2024 · 4 comments · Fixed by #5709

Comments

@ThomasBreuer
Copy link
Contributor

Consider the following input.

F:= FreeGroup(2);
gens:= GeneratorsOfGroup( F );
x:= gens[1];; y:= gens[2];;
rels:= [ y*x^-1*y^-1*x*y^-1*x^-1, x^-1*y*x*y*x^-1*y^-2 ];;
G:= F / rels;
IsomorphismPermGroupOrFailFpGroup(G, 100000);

In GAP 4.12.2, this yields an isomorphism.
In GAP 4.13.0 and in the current master branch, I get fail.

@fingolfin
Copy link
Member

This regression was introduced by PR #5229 resp. commit df91fdb (ping @hulpke)

@fingolfin
Copy link
Member

Thomas' group is just SL(2,5) in disguise:

gap> Size(G);
120
gap> StructureDescription(G);
"SL(2,5)"

@fingolfin
Copy link
Member

Ah OK, so the coset limit is highly relevant. It works with the default CosetTableDefaultMaxLimit$= 4096000$ but not with Thomas' smaller limit. Nor with CosetTableDefaultMaxLimit/10 it turns out. So 409600 cosets are not enough for this group of size 120?

@ThomasBreuer
Copy link
Contributor Author

To be precise: The Size attribute of G is already set when IsomorphismPermGroupOrFailFpGroup returns fail. How can this happen?

hulpke added a commit to hulpke/gap that referenced this issue Apr 5, 2024
even if max parameter was increased in between. This resolves gap-system#5697
hulpke added a commit to hulpke/gap that referenced this issue Apr 5, 2024
in finding induced permutation representation of FpGroup,
even if max parameter was increased in between. This resolves gap-system#5697
hulpke added a commit to hulpke/gap that referenced this issue Apr 5, 2024
in finding induced permutation representation of FpGroup,
even if max parameter was increased in between. This resolves gap-system#5697
fingolfin pushed a commit to fingolfin/gap that referenced this issue May 6, 2024
in finding induced permutation representation of FpGroup,
even if max parameter was increased in between. This resolves gap-system#5697
fingolfin pushed a commit to fingolfin/gap that referenced this issue May 6, 2024
in finding induced permutation representation of FpGroup,
even if max parameter was increased in between. This resolves gap-system#5697
hulpke added a commit to hulpke/gap that referenced this issue May 6, 2024
in finding induced permutation representation of FpGroup,
even if max parameter was increased in between. This resolves gap-system#5697
hulpke added a commit to hulpke/gap that referenced this issue May 6, 2024
even if max parameter was increased in between. This resolves gap-system#5697
fingolfin added a commit that referenced this issue May 6, 2024
in finding induced permutation representation of FpGroup,
even if max parameter was increased in between. This resolves #5697

Co-authored-by: Alexander Hulpke <[email protected]>
fingolfin added a commit that referenced this issue May 6, 2024
in finding induced permutation representation of FpGroup,
even if max parameter was increased in between. This resolves #5697

Co-authored-by: Alexander Hulpke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants