-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undocumented argument for NewFilter/DeclareFilter #4408
Comments
Implications between filters can cause problems when one manually resets a filter for a given object: Shall the implied filters also be reset? |
We discussed this orally, and decided that this feature has been out and in use for too long; so it seems best to just document it. Perhaps with another stern warning that this makes it even more risky to use |
and of `DeclareFilter`. The optional argument `<implied>` of the two functions had been available for a long time, but it was not documented. Now we document it, as dicussed in issue gap-system#4408. (resolves issue gap-system#4408)
The manual gives the signatures
NewFilter( name[, rank] )
andDeclareFilter( name[, rank] )
. But looking at the code, there is a third optional argument:NewFilter( <name>[, <implied>][, <rank>] )
and likewise forDeclareFilter
.As far as I can tell, nothing uses this argument for
NewFilter
, but some callers forDeclareFilter
do; mostly in HPC-GAP code, but also in a few other files, and most importantly, in packages.So I guess we should simply document this extra argument.
The text was updated successfully, but these errors were encountered: