Skip to content

Commit

Permalink
Fix MinimalGeneratingSet for solvable non-pc groups
Browse files Browse the repository at this point in the history
It could end up returning nothing and not invoking TryNextMethod().
This caused a failure in the hap test suite.

This is a recent regression in 4.12.0.
  • Loading branch information
fingolfin committed Sep 9, 2022
1 parent 0c9da51 commit f7e88ec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/grp.gi
Original file line number Diff line number Diff line change
Expand Up @@ -112,16 +112,16 @@ InstallMethod(MinimalGeneratingSet,"test solvable and 2-generator noncyclic",
function(G)
local i;
if not HasIsSolvableGroup(G) and IsSolvableGroup(G) and
CanEasilyComputePcgs(G) then
CanEasilyComputePcgs(G) then
# discovered solvable -- redo
return MinimalGeneratingSet(G);
elif not IsSolvableGroup(G) then
if IsGroup(G) and (not IsCyclic(G)) and HasGeneratorsOfGroup(G)
and Length(GeneratorsOfGroup(G)) = 2 then
return GeneratorsOfGroup(G);
fi;
TryNextMethod();
fi;
TryNextMethod();
end);

#############################################################################
Expand Down

0 comments on commit f7e88ec

Please sign in to comment.