Use SwapMatrixRows/Columns in a few places

gap-system · Nov 12, 2024 · bad562a · bad562a
1 parent 62bd8f0
commit bad562a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 25 deletions.
diff --git a/lib/matrix.gi b/lib/matrix.gi
@@ -1488,11 +1488,10 @@ InstallMethod( DeterminantMatDestructive,
             i := i + 1;
 
             # make its row the current row
+            row := mat[j];
             if i <> j  then
-                row := mat[j];  mat[j] := mat[i];  mat[i] := row;
+                SwapMatrixRows(mat, j, i);
                 sgn := -sgn;
-            else
-                row := mat[j];
             fi;
             piv := row[k];
 
@@ -1566,9 +1565,7 @@ function( mat )
 
             # ... make its row the current row, ...
             if k <> j then
-                row    := mat[j];
-                mat[j] := mat[k];
-                mat[k] := row;
+                SwapMatrixRows(mat, j, k);
                 sgn    := -sgn;
             else
                 row := mat[j];
@@ -1788,31 +1785,19 @@ local R,M,transform,divide,swaprow, swapcol, addcol, addrow, multcol, multrow, l
   fi;
 
   swaprow:=function(a,b)
-  local r;
-    r:=M[a];
-    M[a]:=M[b];
-    M[b]:=r;
+    SwapMatrixRows(M, a, b);
     if transform then
-      r:=left[a];
-      left[a]:=left[b];
-      left[b]:=r;
+      SwapMatrixRows(left, a, b);
       if basmat<>fail then
-        r:=basmat[a];
-        basmat[a]:=basmat[b];
-        basmat[b]:=r;
+        SwapMatrixRows(basmat, a, b);
       fi;
     fi;
   end;
 
   swapcol:=function(a,b)
-  local c;
-    c:=M{[1..l]}[a];
-    M{[1..l]}[a]:=M{[1..l]}[b];
-    M{[1..l]}[b]:=c;
+    SwapMatrixColumns(M, a, b);
     if transform then
-      c:=right{[1..n]}[a];
-      right{[1..n]}[a]:=right{[1..n]}[b];
-      right{[1..n]}[b]:=c;
+      SwapMatrixColumns(right, a, b);
     fi;
   end;
 

diff --git a/lib/zlattice.gi b/lib/zlattice.gi
@@ -196,8 +196,7 @@ InstallGlobalFunction( LinearIndependentColumns, function( mat )
 
             # Swap rows `j' and `i'.
             row:= mat[j];
-            mat[j]:= mat[i];
-            mat[i]:= row;
+            SwapMatrixRows(mat, i, j);
 
             # Normalize column `k'.
             val:= row[k];