Fix NewZero{Matrix,Vector} of length 0

gap-system · Apr 15, 2021 · 3611770 · 3611770
1 parent 0b64ce6
commit 3611770
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/hpcgap/lib/vec8bit.gi b/hpcgap/lib/vec8bit.gi
@@ -1154,7 +1154,7 @@ InstallMethod( NewZeroVector, "for Is8BitVectorRep, GF(q), and an int",
         Error("Is8BitVectorRep only supports base fields with 3 to 256 elements");
     fi;
     v := ListWithIdenticalEntries(i,Zero(f));
-    ConvertToVectorRep(v,Size(f));
+    CONV_VEC8BIT(v,Size(f));
     return v;
   end );
 
@@ -1185,7 +1185,7 @@ InstallMethod( NewZeroMatrix, "for Is8BitMatrixRep, GF(q), and two ints",
     for i in [2..rows] do
         m[i] := ShallowCopy(m[1]);
     od;
-    ConvertToMatrixRep(m,Size(f));
+    ConvertToMatrixRepNC(m,Size(f));
     return m;
   end );
 

diff --git a/lib/vec8bit.gi b/lib/vec8bit.gi
@@ -1111,7 +1111,7 @@ InstallMethod( NewZeroVector, "for Is8BitVectorRep, GF(q), and an int",
         Error("Is8BitVectorRep only supports base fields with 3 to 256 elements");
     fi;
     v := ListWithIdenticalEntries(i,Zero(f));
-    ConvertToVectorRep(v,Size(f));
+    CONV_VEC8BIT(v,Size(f));
     return v;
   end );
 
@@ -1142,7 +1142,7 @@ InstallMethod( NewZeroMatrix, "for Is8BitMatrixRep, GF(q), and two ints",
     for i in [2..rows] do
         m[i] := ShallowCopy(m[1]);
     od;
-    ConvertToMatrixRep(m,Size(f));
+    ConvertToMatrixRepNC(m,Size(f));
     return m;
   end );
 

diff --git a/tst/testinstall/MatrixObj/ZeroMatrix.tst b/tst/testinstall/MatrixObj/ZeroMatrix.tst
@@ -27,15 +27,15 @@ Error, IsGF2MatrixRep only supported over GF(2)
 gap> TestZeroMatrix(Is8BitMatrixRep, GF(3), 2, 3);
 [ [ 0*Z(3), 0*Z(3), 0*Z(3) ], [ 0*Z(3), 0*Z(3), 0*Z(3) ] ]
 gap> TestZeroMatrix(Is8BitMatrixRep, GF(3), 2, 0);
-Error, Assertion failure
+< mutable compressed matrix 2x0 over GF(3) >
 gap> TestZeroMatrix(Is8BitMatrixRep, GF(3), 0, 3);
 Error, Is8BitMatrixRep with zero rows not yet supported
 
 #
 gap> TestZeroMatrix(Is8BitMatrixRep, GF(251), 2, 3);
 [ [ 0*Z(251), 0*Z(251), 0*Z(251) ], [ 0*Z(251), 0*Z(251), 0*Z(251) ] ]
 gap> TestZeroMatrix(Is8BitMatrixRep, GF(251), 2, 0);
-Error, Assertion failure
+< mutable compressed matrix 2x0 over GF(251) >
 gap> TestZeroMatrix(Is8BitMatrixRep, GF(251), 0, 3);
 Error, Is8BitMatrixRep with zero rows not yet supported
 
@@ -114,15 +114,15 @@ gap> ZeroMatrix(GF(3), 2, 3);
 gap> ZeroMatrix(GF(3), 0, 3);
 Error, Is8BitMatrixRep with zero rows not yet supported
 gap> ZeroMatrix(GF(3), 2, 0);
-[ [  ], [  ] ]
+< mutable compressed matrix 2x0 over GF(3) >
 
 #
 gap> ZeroMatrix(GF(4), 2, 3);
 [ [ 0*Z(2), 0*Z(2), 0*Z(2) ], [ 0*Z(2), 0*Z(2), 0*Z(2) ] ]
 gap> ZeroMatrix(GF(4), 0, 3);
 Error, Is8BitMatrixRep with zero rows not yet supported
 gap> ZeroMatrix(GF(4), 2, 0);
-[ [  ], [  ] ]
+< mutable compressed matrix 2x0 over GF(4) >
 
 #
 gap> STOP_TEST("ZeroMatrix.tst");
diff --git a/tst/testinstall/MatrixObj/ZeroVector.tst b/tst/testinstall/MatrixObj/ZeroVector.tst
@@ -21,13 +21,13 @@ Error, IsGF2VectorRep only supported over GF(2)
 gap> TestZeroVector(Is8BitVectorRep, GF(3), 3);
 Error, Assertion failure
 gap> TestZeroVector(Is8BitVectorRep, GF(3), 0);
-Error, Assertion failure
+Error, Z: <q> must be a positive prime power (not the integer 1)
 
 #
 gap> TestZeroVector(Is8BitVectorRep, GF(251), 3);
 Error, Assertion failure
 gap> TestZeroVector(Is8BitVectorRep, GF(251), 0);
-Error, Assertion failure
+Error, Z: <q> must be a positive prime power (not the integer 1)
 
 # test error handling
 gap> TestZeroVector(Is8BitVectorRep, GF(3), -1);
@@ -100,15 +100,15 @@ Error, ZeroVector: length must be non-negative
 gap> ZeroVector(GF(3), 2);
 [ 0*Z(3), 0*Z(3) ]
 gap> ZeroVector(GF(3), 0);
-[  ]
+< mutable compressed vector length 0 over GF(3) >
 gap> ZeroVector(GF(3), -1);
 Error, ZeroVector: length must be non-negative
 
 #
 gap> ZeroVector(GF(4), 2);
 [ 0*Z(2), 0*Z(2) ]
 gap> ZeroVector(GF(4), 0);
-[  ]
+< mutable compressed vector length 0 over GF(4) >
 gap> ZeroVector(GF(4), -1);
 Error, ZeroVector: length must be non-negative