Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socle type for natural An/Sn in deg >= 2500 #49

Merged

Conversation

fingolfin
Copy link
Member

See #40

@hulpke @alex-konovalov you are both listed as maintainers for primgrp. Please let me know if you are interested in doing so (and then merge this PR and perhaps my others, and make a new release). If not, that's fine, then I can step in and make either myself or "the GAP Team" maintainer.

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #49 (d80f6e7) into master (79d96e1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          46       46           
  Lines      382939   382939           
=======================================
  Hits       382634   382634           
  Misses        305      305           
Impacted Files Coverage Δ
data/gps25.g 100.00% <100.00%> (ø)
data/gps26.g 100.00% <100.00%> (ø)
data/gps27.g 100.00% <100.00%> (ø)
data/gps28.g 100.00% <100.00%> (ø)
data/gps29.g 100.00% <100.00%> (ø)
data/gps30.g 100.00% <100.00%> (ø)
data/gps31.g 100.00% <100.00%> (ø)
data/gps32.g 100.00% <100.00%> (ø)
data/gps33.g 100.00% <100.00%> (ø)
data/gps34.g 100.00% <100.00%> (ø)
... and 5 more

@hulpke hulpke merged commit 453b8b9 into gap-packages:master Dec 3, 2022
@fingolfin fingolfin deleted the mh/fix-SocleTypePrimitiveGroup branch December 5, 2022 09:08
@olexandr-konovalov
Copy link
Member

@fingolfin I think adding you as a maintainer will be helpful, thanks!

@wilfwilson
Copy link
Member

Did this resolve #40 @fingolfin? (That issue is still open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants