use ACE 4.1 #36

dimpase · 2023-03-13T00:17:53Z

this will fix #8

dimpase · 2023-03-13T09:38:42Z

The test tst/aceds.tst hangs at

...
gap> stats:=ACEStats( i );; Unbind(stats.cputime); stats;
rec( activecosets := 80, cputimeUnits := "10^-2 seconds", 
  index := 80, maxcosets := 123, totcosets := 187 )
gap> ACEDeleteSubgroupGenerators( i, [ t ] );

hitting ^C gives

^CError, user interrupt in
  moreOfline := ReadLine( iostream )
 ; at /mnt/opt/gap/lib/streams.gi:1478 called from 
ReadAllLine( iostream, nofail, function ( line )
      return 0 < Length( line ) and line[Length( line )] = '\n';
  end ) at /mnt/opt/gap/lib/streams.gi:1498 called from
ReadAllLine( iostream, true 
 ) at /mnt/opt/gap/pkg/ace/gap/streams.gi:40 called from
readline( iostream ) at /mnt/opt/gap/pkg/ace/gap/streams.gi:61 called from
FLUSH_ACE_STREAM_UNTIL( datarec.stream, 3, 3, ACE_READ_NEXT_LINE
  , function ( line )
      return IsMatchingSublist( line, "  #--" );
  end ); at /mnt/opt/gap/pkg/ace/gap/interact.gi:1504 called from
ACE_ARGS( ioIndexAndOptval[1], "sgens" 
 ) at /mnt/opt/gap/pkg/ace/gap/interact.gi:2538 called from
...  at *stdin*:9
you can 'return;'
brk>

Probably another ACE output parsing bug.

correct reported ACE binary version

dimpase · 2023-03-13T13:08:55Z

todo:

get rid of statistics/stats ACE binary options - they are removed in ACE4 - in particular ACEDumpStatistics
fix ACEBinaryVersion - it breaks due to parsing for host in gap/interact.gi:1612
sort out and remove parsing for host info in gap/options.gi: options := line -> IsMatchingSublist(line, " host info")
remove statistics/stats and host stuff from the docs
remove ACEDumpVariables, as dump ACE command has been removed (cf. src/Diary)

statistics package was removed from ACE 4. "options;" ACE command produces different output in diffent state of the enumerator - perhaps, we can just remove ACEBinaryVersion all together

codecov · 2023-03-13T17:30:42Z

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 38.46%. Comparing base (ac8eb7b) to head (0a1dc19).

❗ Current head 0a1dc19 differs from pull request most recent head 720621a

Please upload reports for the commit 720621a to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   38.82%   38.46%   -0.37%     
==========================================
  Files          10       10              
  Lines        2761     2704      -57     
==========================================
- Hits         1072     1040      -32     
+ Misses       1689     1664      -25

Files	Coverage Δ
gap/interact.gd	`100.00% <ø> (ø)`
gap/options.gi	`55.95% <100.00%> (-1.09%)`	⬇️
gap/general.gi	`30.40% <50.00%> (-0.85%)`	⬇️
gap/interact.gi	`23.91% <25.00%> (+0.02%)`	⬆️

dimpase · 2023-03-13T17:33:52Z

All what ACEBinaryVersion is printing with ACE4 is

gap> ACEBinaryVersion();
#I  No interactive ACE sessions are currently active
#I  ACE Binary Version: 4.100
#I  ACE 4.100                       Mon Mar 13 16:45:40 2023
#I  ========================================================
"4.100"

and it breaks if there was some activity enumerating cosets before - due to a parsing error of the output.
I think it makes little sense to keep it, I'll remove it.

reverting this commit will re-surface an ACE4-specific bug, which makes ACEBinaryVersion hang if there is an active ACE session.

dimpase · 2023-03-14T12:21:45Z

Removed ACE command in 4.1 to take care of:

ai and ao (alter input/output)
ho - hole limit
par[ameters] - old option (ignored)
restart - old option (ignored)
pd mo[de] / pmod[e] : [0/1..3] ; becomes (?) pd[efinitions] : [0/1] ;
dump, stats

dimpase · 2023-03-14T12:31:51Z

Changed in ACE4 commands:

pr, as confirmed by Colin Ramsey 2023-03-13:

takes two arguments, the beginning and ending
coset.  If the arguments are negative they mean (respectively) add
order/representative columns to the table and include coincident coset rows. 
To compact and standardise the coset table you need to invoke st; before pr;,
as you note.

So our change (to always call st before pr) makes perfect sense.

It all works, except that the option aceiputfile to write the ACE input in an external file writes there the line aceinputile: <file name> - which ACE4 does not understand, but happily ignores. So this is a minor quirk.

1) "a set of figures detailing the control flow in the state machine that is at the core of the enumerator (see the enum.c & enum0n.inc source files)." 2) example demonstrating new functionality of "pr;" command: "The print table now takes two arguments, the beginning and ending coset. If the arguments are negative they mean (respectively) add order/representative columns to the table and include coincident coset rows. To compact and standardise the coset table you need to invoke st; before pr;."

dimpase · 2023-11-29T11:12:36Z

Anyhow, this is working, the only issue here to resolve is that the docbuld action lives in my GitHub fork.

fingolfin · 2023-11-29T12:08:28Z

No need for a special action. You can just insert a step which installs the "missing" packages. E.g. https://github.com/gap-packages/polymaking/blob/master/.github/workflows/CI.yml does this to install polymake

dimpase · 2023-11-29T12:15:31Z

No need for a special action. You can just insert a step which installs the "missing" packages. E.g. https://github.com/gap-packages/polymaking/blob/master/.github/workflows/CI.yml does this to install polymake

I've modified https://github.com/dimpase/build-pkg-docs/blob/patch-1/action.yml so that installing xetex and metapost is optional, and doesn't happen by default. If this is too special to your taste, I can probably change it so that optionally
one can specify arbitrary extra Debian packages to install, not a fixed list.

dimpase · 2023-11-29T12:28:29Z

OK, now d8382f5 does what you suggest.

(I feel like yaml is slowly swapping in my brain to take place of some other language in cache 🥲 )

dimpase · 2023-11-29T12:29:34Z

some commits can certainly be squashed if needed

dimpase · 2023-12-01T16:15:39Z

@hulpke

hulpke · 2023-12-01T16:17:22Z

@hulpke

? Yes ? What ?

dimpase · 2023-12-01T16:50:35Z

Please review if possible

hulpke

I have no objection and suggest we merge these changes, but do not have time to check details.

dimpase · 2024-01-30T09:51:26Z

I'm asking Leonard @lhsoicher to test this.

dimpase · 2024-02-06T12:16:25Z

@gregg0 - are you still following this?

gregg0 · 2024-02-06T15:17:01Z

Dear Dima, I don’t understand what’s being done. Is there something that explains it? Regards, Greg Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Dima Pasechnik ***@***.***> Sent: Tuesday, February 6, 2024 8:16:37 PM To: gap-packages/ace ***@***.***> Cc: Gregory Gamble ***@***.***>; Mention ***@***.***> Subject: Re: [gap-packages/ace] use ACE 4.1 (PR #36) @gregg0<https://github.com/gregg0> - are you still following this? — Reply to this email directly, view it on GitHub<#36 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABKQEEH2JD252AFDKSVUSBTYSINKLAVCNFSM6AAAAAAVYNPIR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGQYDANBRG4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

dimpase · 2024-02-06T15:50:14Z

Colin released an update to ACE, and I used it to update the package, adding documentation building along the way.

gregg0 · 2024-02-06T16:20:26Z

Dear Dima, I always found the way github did things hard to get started with, and was so grateful when Max got involved. But it looks like I really have to get my head around it now, because other things - websites - I'm involved with have moved to github. Anyway, I trust your work ... so I won't hold you up, and I'll try to look at what your work soon. Regards, Greg Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Dima Pasechnik ***@***.***> Sent: Tuesday, February 6, 2024 11:50:25 PM To: gap-packages/ace ***@***.***> Cc: Gregory Gamble ***@***.***>; Mention ***@***.***> Subject: Re: [gap-packages/ace] use ACE 4.1 (PR #36) Colin released an update to ACE, and I used it to update the package, adding documentation building along the way. — Reply to this email directly, view it on GitHub<#36 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABKQEEASEVW7DRDMBUPKNKDYSJGMDAVCNFSM6AAAAAAVYNPIR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQGA4TKOJXGI>. You are receiving this because you were mentioned.Message ID: ***@***.***>

fingolfin

This is a huge change, I don't have time to review it properly right now. Just some quick comments, though

PackageInfo.g

.release

README.md

doc/ace.tex

CHANGES.md

fingolfin · 2024-02-06T17:21:45Z

doc/make_doc

 # Create PDF version
-pdftex manual; pdftex manual
+xetex manual


Why the switch from tex and pdftex to xetex?

well, xetex is faster, can take unicode, and produces smaller pdf files. And more modern, too. The better question IMHO is why GAP stays on the old tech :-)

I also spent time (using xelatex) adjusting graphics generated in the docs by metapost. And changed manual to use modern graphics stack, and not some outdated postscript-based stuff. I don't think it's necessary to re-do this on the old TeX stack.

PS. Back in Nov 2023 you didn't question the need for xetex, see #36 (comment)

doc/strategies.tex

Co-authored-by: Max Horn <[email protected]>

dimpase · 2024-02-08T00:10:39Z

Thanks for the review. I'll continue updating tomorrow. :-)

Co-authored-by: Max Horn <[email protected]>

dimpase · 2024-02-08T12:57:21Z

OK, I think I've addressed everything.

And marked what I thought as clear as resolved (perhaps I should not have?)

I hope you don't mind xetex.

dimpase · 2024-05-26T22:27:26Z

well, what can I do to get this reviewed?

dimpase added 3 commits March 12, 2023 23:19

preparation for ACE 4.1: standardise coset tables, skip banner correctly

56227e7

ACE3 src to src.old, ACE4 src to src

8aa2fb3

bump version, add ACE4 manual

dc566ec

dimpase marked this pull request as draft March 13, 2023 00:18

dimpase and others added 4 commits March 13, 2023 10:00

correct reported ACE binary version

c8d2377

fix output parsing for subgroup gens (after ACE's "ds")

9795812

Merge pull request #1 from dimpase/dimpase-patch-1

ca68993

correct reported ACE binary version

adjust test output

14927b5

dimpase added 4 commits March 13, 2023 14:02

fix parsing for ACEBinaryVersion()

0f18e7f

adjust parising for ACEBinaryVersion, remove stat(istics)

6653d33

statistics package was removed from ACE 4. "options;" ACE command produces different output in diffent state of the enumerator - perhaps, we can just remove ACEBinaryVersion all together

remove ACEDumpVariables, as it relies on removed "dump" ACE command

75aa044

remote traces of host stuff from docs

3eeb8a9

dimpase added 2 commits March 13, 2023 17:40

remove ACEBinaryVersion as not giving anything intersting for ACE4

f80e2b4

reverting this commit will re-surface an ACE4-specific bug, which makes ACEBinaryVersion hang if there is an active ACE session.

more of cleaning "stats" ACE option

a6b379e

dimpase added 10 commits March 14, 2023 18:58

removing ao and ai options, part I

4b614da

It all works, except that the option aceiputfile to write the ACE input in an external file writes there the line aceinputile: <file name> - which ACE4 does not understand, but happily ignores. So this is a minor quirk.

remove ignored options

64e1a68

remove old "hole" option

3231705

remove 'pmode' old option

b8e5fc6

removed old sources, moved tests/ and ex/ to src/

2b7834c

removed hardcoded gcc from Makefile

c4c240f

administrativia updates

7f40f05

removed a duplicate reference

ba22b37

fix typo

f349d7f

use updated docs action in CI.yml

76eb0b2

explicitly install xetex and metapost in CI.yml

d8382f5

hulpke approved these changes Dec 1, 2023

View reviewed changes

fingolfin reviewed Feb 7, 2024

View reviewed changes

dimpase and others added 3 commits February 7, 2024 23:22

add missing ')'

4399445

Co-authored-by: Max Horn <[email protected]>

add DEV to version #

4f9a345

Co-authored-by: Max Horn <[email protected]>

Update .release

6e01f32

Co-authored-by: Max Horn <[email protected]>

dimpase and others added 5 commits February 8, 2024 12:00

Update README.md

6e94401

Co-authored-by: Max Horn <[email protected]>

replace tabs with spaces

b1103b3

expand CHANGES, rename stadoc to otherdoc

0b46e3c

remote pmode, adjust tables

f6ab03d

added DEV to 5.7.0 everywhere else

0a1dc19

dimpase mentioned this pull request Mar 14, 2024

Computing elements of an fp-group of order 200 running out of memory gap-system/gap#5671

Closed

Merge branch 'master' into master

720621a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use ACE 4.1 #36

use ACE 4.1 #36

dimpase commented Mar 13, 2023

dimpase commented Mar 13, 2023

dimpase commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 13, 2023 •

edited

Loading

dimpase commented Mar 13, 2023

dimpase commented Mar 14, 2023 •

edited

Loading

dimpase commented Mar 14, 2023 •

edited

Loading

dimpase commented Nov 29, 2023

fingolfin commented Nov 29, 2023

dimpase commented Nov 29, 2023

dimpase commented Nov 29, 2023

dimpase commented Nov 29, 2023

dimpase commented Dec 1, 2023

hulpke commented Dec 1, 2023

dimpase commented Dec 1, 2023

hulpke left a comment

dimpase commented Jan 30, 2024

dimpase commented Feb 6, 2024

gregg0 commented Feb 6, 2024 via email

dimpase commented Feb 6, 2024

gregg0 commented Feb 6, 2024 via email

fingolfin left a comment

fingolfin Feb 6, 2024

dimpase Feb 8, 2024

dimpase Feb 8, 2024 •

edited

Loading

dimpase commented Feb 8, 2024

dimpase commented Feb 8, 2024

dimpase commented May 26, 2024

use ACE 4.1 #36

Are you sure you want to change the base?

use ACE 4.1 #36

Conversation

dimpase commented Mar 13, 2023

dimpase commented Mar 13, 2023

dimpase commented Mar 13, 2023 • edited Loading

codecov bot commented Mar 13, 2023 • edited Loading

Codecov Report

dimpase commented Mar 13, 2023

dimpase commented Mar 14, 2023 • edited Loading

dimpase commented Mar 14, 2023 • edited Loading

dimpase commented Nov 29, 2023

fingolfin commented Nov 29, 2023

dimpase commented Nov 29, 2023

dimpase commented Nov 29, 2023

dimpase commented Nov 29, 2023

dimpase commented Dec 1, 2023

hulpke commented Dec 1, 2023

dimpase commented Dec 1, 2023

hulpke left a comment

Choose a reason for hiding this comment

dimpase commented Jan 30, 2024

dimpase commented Feb 6, 2024

gregg0 commented Feb 6, 2024 via email

dimpase commented Feb 6, 2024

gregg0 commented Feb 6, 2024 via email

fingolfin left a comment

Choose a reason for hiding this comment

fingolfin Feb 6, 2024

Choose a reason for hiding this comment

dimpase Feb 8, 2024

Choose a reason for hiding this comment

dimpase Feb 8, 2024 • edited Loading

Choose a reason for hiding this comment

dimpase commented Feb 8, 2024

dimpase commented Feb 8, 2024

dimpase commented May 26, 2024

dimpase commented Mar 13, 2023 •

edited

Loading

codecov bot commented Mar 13, 2023 •

edited

Loading

dimpase commented Mar 14, 2023 •

edited

Loading

dimpase commented Mar 14, 2023 •

edited

Loading

dimpase Feb 8, 2024 •

edited

Loading